This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Repository navigation
[build] Added 'lint' Make target - #5411
Merged
Merged
Conversation
Contributor
Author
|
Note: We might want to disable |
brunoabinader
force-pushed
the
brunoabinader-lint
branch
from
July 1, 2016 07:07
e5b3fb1 to
ede0e67
Compare
Contributor
Author
|
Per conversation with @tmpsantos - I'll rename the current |
Contributor
There was a problem hiding this comment.
if compdb is not a dep of lint-linux, running make lint-linux could fail no?
Contributor
Author
There was a problem hiding this comment.
We shouldn't need to call make lint-linux directly - make lint is smart enough to trigger its platform-specific variant.
brunoabinader
force-pushed
the
brunoabinader-lint
branch
from
July 1, 2016 08:20
ede0e67 to
da863c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new Makefile target named
lint- it is meant to run bothclang-tidyandclang-formatchecks only on modified code from your local branch.Example:
new-feature, which tracksorigin/master.make lintand if there any changes made by eitherclang-tidyorclang-format, Rachel reviews and applies the changes before submitting upstream.Caveats:
origin..clang-formatin GL native, but we might want to share it with Adds a .clang-format config everyone can agree on cpp-bootstrap#7.Fixes #5342.
👀 @mapbox/gl