This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Enforce code style with clang-format #5342
Description
We've re-enabled clang-tidy checks as part of establishing good practices in our code changes. Keeping in line with that, we should start using clang-format - it automatically formats C++ code according to a set of configuration options - we actually maintain a .clang-format config already.
As @kkaefer suggested, we should have a bot that:
- Runs
clang-format -iovermapbox-gl-nativecodebase; - Runs
git diff, then fails if there are any differences (showing diff output for reference).
👀 @mapbox/gl
Activity
mikemorris commentedon Jun 14, 2016
Any way that we could script this into
make testornpm testinstead of relying on CI?brunoabinader commentedon Jun 14, 2016
Yes, there will be a Makefile target for that - I suggest
make checkto separate it from unit test runs 👍 .Intent of adding it to CI is to prevent people from committing code that would eventually need to be sanitized later. Unlike
clang-tidy, though,clang-formatruns pretty fast (takes a couple seconds to perform) so I believe that won't be an issue.