This repository was archived by the owner on Aug 8, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Aug 8, 2023. It is now read-only.
[tidy] Run clang-tidy checks for platform-specific code #5349
Description
Follow-up for #5341 - there are some platform-specific code not being verified by the clang-tidy bot because it doesn't get compiled for Linux.
To address that, we'd need to run clang-tidy checks for each supported platform (Android, iOS, Node, Qt, Linux, macOS...). While it seems like a lot of extra effort, the runtime for platform-specific checks would be quite low because we'd only need to scan platform/*.cpp for each of these platforms.
My idea is to add an extra step on each of the build bots we have for this, and have a separate clang-tidy bot that only checks src/mbgl/*.cpp & test/*.cpp.
Thoughts?
Activity
jfirebaugh commentedon Jun 14, 2016
Is there a way to integrate the clang tidy checks in the normal compile process? Ideally they just work like other compiler warnings/errors:
brunoabinader commentedon Jun 22, 2016
@jfirebaugh I am proposing a
lintchecktarget that can be integrated with regular build process in #5411.stale commentedon Nov 29, 2018
This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.