Napi version in node-gyp #371

Activity

1. mhdawson

   added this to the Milestone 11 milestone on May 9, 2019
2. jschlight commented on May 14, 2019

   

   jschlight

   on May 14, 2019

   Collaborator

   More actions

   With node-pre-gyp and prebuild, the N-API version is essentially specified by the user and then the actual N-API version being built against is communicated into the binding.gyp file using a new napi-build-version variable we created for the purpose.

   In the linked issue, the user is requesting that node-gyp inform the binding.gyp file which N-API version is supported by the version of Node being built against.

   It's like the opposite of what we implemented for node-pre-gyp and prebuild.
3. richardlau commented on May 23, 2019

   

   richardlau

   on May 23, 2019

   Member

   More actions

   A PR was opened against core: nodejs/node#27800
4. NickNaso commented on May 23, 2019

   

   NickNaso

   on May 23, 2019

   Member

   More actions

   Hi everyone,
   I closed my previous PR and reopened new one nodejs/node#27835. Please if you have time take a look.
5. NickNaso commented on Jun 7, 2019

   

   NickNaso

   on Jun 7, 2019

   Member

   More actions

   Hi everyone,
   if someone has time could take a look at this PR nodejs/node#27835 in particular the last two comments? I need a feedback.
6. pull

   added a commit that references this issue on Jul 2, 2019

   build: expose napi_build_version variable

   ...

   9868126
7. targos

   added 2 commits that reference this issue on Jul 2, 2019

   build: expose napi_build_version variable

   ...

   9b735b1

   build: expose napi_build_version variable

   ...

   cd71aad
8. NickNaso commented on Jul 3, 2019

   

   NickNaso

   on Jul 3, 2019

   Member

   More actions

   I’m closing this because the PR has been landed yesterday and the work now is on Node.js 12.6.0
9. NickNaso

   closed this as completedon Jul 3, 2019
10. richardlau

    added a commit that references this issue on Oct 7, 2020

    build: expose napi_build_version variable

    ...

    b83f9a5