Expose napi version as a node-gyp variable #1745

Activity

1. mhdawson commented on May 13, 2019

   

   mhdawson

   on May 13, 2019

   Member

   More actions

   We discussed in the N-API team meeting today.

   Jim mentioned that the N-API team (and by that I mean Jim :)) added the concept a Napi-version to node-pre-gyp and prebuild. @jschlight will take a look at whether something similar makes sense for node-gyp.
2. richardlau commented on May 13, 2019

   

   richardlau

   on May 13, 2019

   Member

   More actions

   For my module I want to do conditional compilation based on node-gyp feature support.

   Unfortunately there's currently no nice way to figure out at node-gyp configuration time which napi version is supported. I'm currently doing this:

     'variables': {
       'napi_version': '<!(node -e "console.log(process.versions.napi)")',
     },
   

   But this checks napi support in the host version of nodejs, not in the nodejs build target version.

   Is the desired variable NAPI_VERSION from node_version.h? If so something like this:

     'variables': {
       'napi_version': '<!(awk \'$1 == "#define" && $2 == "NAPI_VERSION" {print $3}\' <(node_root_dir)/include/node/node_version.h)'
     },
   

   (doesn't have to be awk -- the main thing is <(node_root_dir)/include/node/node_version.h) which is the header files being compiled against (node_root_dir is set by node-gyp)).
3. josephg commented on May 13, 2019

   

   josephg

   on May 13, 2019

   Author

   More actions

   Yeah NAPI_VERSION is what I’m after. That’d do the trick, although it wouldn’t work on windows because there’s no awk there. For my project I’ve landed on an awful workaround of just making a bunch of indirect source files that conditionally include the right source files. It’d be nice to sort this out via gyp though.
4. richardlau commented on May 13, 2019

   

   richardlau

   on May 13, 2019

   Member

   More actions

   Maybe something like the following for cross-platform (looks messy because of the needed escaping):

     'variables': {
       'napi_version': '<!(node -p "require(\'fs\').readFileSync(\'<(node_root_dir)/include/node/node_version.h\', \'utf8\').match(/NAPI_VERSION\\s*(\\d+)/)[1]")'
     },
   

   Definitely not opposed to having node-gyp define a napi_version variable for use in binding.gyp files, but bear in mind it would take a while to filter through to dependents, e.g. npm (and, for example, the default version of npm in, say, Node.js 8, and by extension its version of node-gyp is unlikely to get updated).
5. jschlight commented on May 14, 2019

   

   jschlight

   on May 14, 2019

   More actions

   node-pre-gyp and prebuild permit the user to request multiple builds using node-gyp. For both tools we defined a new node-gyp variable napi_build_version, accessible in the binding.gyp file, that communicates the N-API version the tool is requesting to build.

   I think the work we did there does not apply to this situation.
6. bnoordhuis commented on May 16, 2019

   

   bnoordhuis

   on May 16, 2019

   Member

   More actions

   node-gyp isn't the right place to embed that logic. If node exposes a napi_build_version through its common.gypi, node-gyp will automagically make it available to add-ons. I suggest moving this to nodejs/node.

   👍React with 👍2Reacted by Seph Gentle and Gabriel Schulhof
7. bnoordhuis commented on Jun 20, 2019

   

   bnoordhuis

   on Jun 20, 2019

   Member

   More actions

   There's an open pull request over at nodejs/node that is this close to landing so I'll go ahead and close out this issue.
8. bnoordhuis

   closed this as completedon Jun 20, 2019
9. pull

   added a commit that references this issue on Jul 2, 2019

   build: expose napi_build_version variable

   ...

   9868126
10. targos

    added 2 commits that reference this issue on Jul 2, 2019

    build: expose napi_build_version variable

    ...

    9b735b1

    build: expose napi_build_version variable

    ...

    cd71aad
11. richardlau

    added a commit that references this issue on Oct 7, 2020

    build: expose napi_build_version variable

    ...

    b83f9a5