Repository navigation
fix(ui): align timeline avatars with the sender's byline - #127
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93. Part of #5.
Group avatars and comment-event glyphs in the timeline now sit at the top of the row, next to the sender's byline, instead of next to the first bubble.
GroupAvatarno longer addsBYLINE_HEIGHT + HEADER_GAPpadding above the avatar.itemHeightsets the row's minimum height toAVATAR + AVATAR_NUDGE, the same as event rows, so one-line groups don't clip the avatar or get extra space.prCommentGlyphOffset()to put their glyph next to the bubble. They now useAVATAR_NUDGE, like every other system row (commits, PRs, terminal, presence), so they line up with message rows.eventGlyphreturns only the icon.Checks:
bun typesandbun run cipass. I checked the lane's UI with a temporary Vite server connected to the dev host. In this channel, both the human and agent avatars start at the top of their byline (avatar top at y=181pt, byline top ≈179pt plus the 2px nudge).Built in Ace
Built in Ace. The visual check ran the lane's app in Safari through Ace's desktop tools. Chrome Accessibility inspection failed on a title mismatch (#113).