Repository navigation
feat: adopt Codex 0.154 async questions across web and WebXR - #167
Conversation
|
@codex review Focus on regressions in the Codex 0.154 async-question flow and its web/WebXR response routing, lifecycle, and draft preservation, within this PR's stated scope. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa53636f31
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa53636f31
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Verify the review fixes for async-question progress and per-question custom draft preservation across drawer dismissal, auto-close, replacement/remount, and transcript reopening. Also check successful-send acknowledgements arriving after dismissal or thread navigation: they must update only the originating workspace/thread/item and must not advance unrelated requests or clear newer drafts. Focus on regressions caused by this six-file fix within the original async-question lifecycle contract. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 866bc05bfa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Verify only the follow-up fix for the concrete late-acknowledgement/remount regression raised in the preceding review. Shared per-item in-flight state should preserve the submitted draft and prevent edits/duplicate sends after returning to the originating chat; delayed success/failure must affect only that workspace/thread/item, while other threads remain usable. Check the captured-draft deletion guard and the focused remount/race tests. Keep the review within this changed submission lifecycle contract. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46970fd1db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Upgrade the bundled Codex runtime to 0.154.0 and regenerate the experimental app-server TypeScript bindings. Async questions now remain actionable instead of appearing only as plain assistant text.
[User Answer]badge in transcript history reopens it.The protocol/web changes and WebXR implementation are separate commits.
Validation
fa53636, including lint, typecheck, tests, and build. The WIP check remains pending while this PR is a draft.Limits
The XR scene is verified in a desktop browser and automated state/interaction tests; native keyboard display, physical-headset ergonomics, and hand tracking still need device validation. Full-history reads remain compatible with 0.154, although upstream now emits a deprecation notice for paginated threads. Device user-verification requests continue to use the existing unsupported-request decline path.