Skip to content

feat: adopt Codex 0.154 async questions across web and WebXR - #167

Merged
comfuture merged 4 commits into
mainfrom
feat/codex-app-server-0.154
Oct 7, 2026
Merged

comfuture merged 4 commits into
mainfrom
feat/codex-app-server-0.154

Conversation

@comfuture

@comfuture comfuture commented Sep 12, 2026 •

Copy link
Copy Markdown
Owner

Summary

Upgrade the bundled Codex runtime to 0.154.0 and regenerate the experimental app-server TypeScript bindings. Async questions now remain actionable instead of appearing only as plain assistant text.

  • Reuse the web request drawer for async questions. Users can dismiss it at any time; two distinct subsequent turn starts close it automatically. A [User Answer] badge in transcript history reopens it.
  • Show one question at a time. Clicking an option sends that answer immediately; custom text uses Send response. Keep the ordinary composer draft, attachments, and mentions intact, and guard answer routing against thread changes during runtime setup.
  • Add a separate persistent WebXR question panel in the existing 3D scene at the lower center of the view, with chamfered glass, segmented neon rails, and controller/hand/pointer interaction. Focusing its text field uses the browser's native input and system keyboard rather than an in-panel keyboard. It supports IME input, preserves dismissed drafts, and does not inherit web turn expiry or tool-panel inactivity expiry.
  • Render standalone function outputs, accept supported OpenAI elicitation form aliases, use configured thread model metadata during read-only hydration, and correct usage percentages, Unix reset timestamps, backend usage permission, and account-switch state.

The protocol/web changes and WebXR implementation are separate commits.

Validation

  • Workspace lint and typecheck, 1,105 tests (client 636, server 263, WebXR 206; one server test skipped), and the complete client/WebXR/server/CLI production build pass locally.
  • GitHub Actions validate passed on fa53636, including lint, typecheck, tests, and build. The WIP check remains pending while this PR is a draft.
  • Bundled Codex 0.154.0 stdio smoke: initialization, model/list, account/rateLimits/read, project/list, thread/list, and metadata thread/read succeeded without mutating a real conversation.
  • Desktop/mobile browser QA covers drawer dismissal, expiry after two subsequent turns, history reopening, immediate option submission, and explicit custom responses.
  • The production XR scene was exercised through a temporary browser preview with mock transport: option submission, native textarea focus, Korean text rendering, dismiss/reopen draft preservation, explicit custom submission, and pointer hover. No preview fixture is shipped.

Limits

The XR scene is verified in a desktop browser and automated state/interaction tests; native keyboard display, physical-headset ergonomics, and hand tracking still need device validation. Full-history reads remain compatible with 0.154, although upstream now emits a deprecation notice for paginated threads. Device user-verification requests continue to use the existing unsupported-request decline path.

@comfuture
comfuture marked this pull request as ready for review October 6, 2026 23:38

Copy link
Copy Markdown
Owner Author

@codex review
Review head: fa53636f314d07051cf4d6f318126c0d22ce964e

Focus on regressions in the Codex 0.154 async-question flow and its web/WebXR response routing, lifecycle, and draft preservation, within this PR's stated scope.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fa53636f31

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/client/app/components/ChatWorkspace.vue
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T00:11:15.687601Z 46970fd Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fa53636f31

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/client/app/components/message-part/AsyncQuestions.vue Outdated

Copy link
Copy Markdown
Owner Author

@codex review
Review head: 866bc05bfa01bee1e75c27ff4acff75af23db5c8

Verify the review fixes for async-question progress and per-question custom draft preservation across drawer dismissal, auto-close, replacement/remount, and transcript reopening. Also check successful-send acknowledgements arriving after dismissal or thread navigation: they must update only the originating workspace/thread/item and must not advance unrelated requests or clear newer drafts. Focus on regressions caused by this six-file fix within the original async-question lifecycle contract.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 866bc05bfa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/client/app/composables/useAsyncUserQuestions.ts Outdated

Copy link
Copy Markdown
Owner Author

@codex review
Review head: 46970fd1dbca7a71488da13e359bbbec6f80207b

Verify only the follow-up fix for the concrete late-acknowledgement/remount regression raised in the preceding review. Shared per-item in-flight state should preserve the submitted draft and prevent edits/duplicate sends after returning to the originating chat; delayed success/failure must affect only that workspace/thread/item, while other threads remain usable. Check the captured-draft deletion guard and the focused remount/race tests. Keep the review within this changed submission lifecycle contract.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 46970fd1db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/client/app/components/ChatWorkspace.vue
@comfuture
comfuture merged commit 3dac378 into main Oct 7, 2026
2 checks passed
@comfuture
comfuture deleted the feat/codex-app-server-0.154 branch October 7, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant