Repository navigation
fix(dsh): honor configured skill installation paths - #827
Open
specetator wants to merge 1 commit into
Open
specetator wants to merge 1 commit into
specetator wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugins.dsh.memory_to_skill.pathsdestination when installing a skill from the DSH review dock.memsearch config list --json-outputinterface, instead of parsingconfig get's Python list representation as JSON.Problem and production evidence
The DSH platform reference explicitly says configured relative destinations resolve against the project directory. The real
skills installimplementation follows the same rule after expanding~.The production
/memsearch-dsh/skill-reviewinstall handler callsresolveSkillInstallTarget, then starts the actual CLI withskills install NAME --path TARGETand the session's project cwd. For ordinary configured paths,config getreturns Python repr (for example['./configured-skills']), which the old resolver cannot parse as JSON. A real CLI + registered production route-handler test confirmed that the candidate was installed in~/.agents/skillsinstead of the configured directory.A path containing a single quote can make Python repr valid JSON. Relative paths of this kind already worked and are preserved. Absolute paths of this kind exposed the second bug:
join(first, first)duplicated the absolute path. The regression fixture reflects these different real CLI formats rather than assuming all configured paths failed.Validation
uv run python -m pytest tests/test_skills.py tests/test_config.py -q: 71 passed, under an isolated HOME.~/, quotes/spaces, first of multiple paths, empty/default), verifying actual installed files and their contents. In all six, untrusted project config could not override the global plugin path.ruff check src/ tests/,ruff format --check src/ tests/, andgit diff --checkpassed.Limitations and AI disclosure
This change and its tests were prepared with AI assistance and independently reviewed by another AI agent; this is not human review. Validation was on Linux only. The route integration uses fixture HTTP request/response and DSH context objects but real production route registration, configuration CLI, installation CLI, and filesystem operations. It is not a live browser or complete DSH-host lifecycle test. No real model/provider calls were made, and the full Python suite/all-extras and Windows runtime were not run.
An initial associated Python test run hit the environment's read-only default home directory (70 passed / 1 environment failure); rerunning with a dedicated writable test HOME passed all 71 without changing production code or permissions.