Repository navigation
Conversation
Signed-off-by: masachika shiotsuka <n2655f@labs.aizu.ac.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3272.
Reproduction
With Zig 0.16.0 / ZLS 0.16.0:
ZLS reports
xasnoreturn, while Zig resolves the loop expression tou32. The same issue occurs when theelseclause is a concrete value: its type is used without considering the typedbreakvalue.Cause
The loop analysis returned the
elseexpression's type before inspectingbreak <value>operands. A non-returningelseclause therefore prevented the loop body's result from being considered.Fix
Only use the
elsetype as the immediate result when it is notnoreturn. Otherwise, continue through the existingBreakIteratorpath and infer the result from the break operand.Verification
tests/analysis/loop_expr_type.zigregression coverage for anoreturnelse clause and a value-returning else clause.zig build test-analysis -Dtest-filter=loop_expr_typepassed.zig build test-analysispassed.zig fmt --check src/analysis.zig tests/analysis/loop_expr_type.zigpassed.git diff --checkpassed.Unverified
The full LSP client matrix and platform-specific builds were not run.
AI disclosure
This patch and PR description were prepared with AI assistance. The reproduction, code inspection, implementation, and tests were performed locally against the current default branch.