Skip to content

feat: add rugby completion spec - #2105

Merged
grant0417 merged 2 commits into
withfig:masterfrom
swiftyfinch:master
Oct 12, 2023
Merged

grant0417 merged 2 commits into
withfig:masterfrom
swiftyfinch:master

Conversation

@swiftyfinch

@swiftyfinch swiftyfinch commented Sep 30, 2023 •

Copy link
Copy Markdown
Contributor

Hello!

I've just added a new Fig autocomplete spec for Rugby 🏈.
https://github.com/swiftyfinch/Rugby

I read and followed the guide:

  • npm run test
  • npm run lint:fix

@withfig-bot

withfig-bot commented Sep 30, 2023 •

Copy link
Copy Markdown
Contributor

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@withfig-bot

withfig-bot commented Sep 30, 2023 •

Copy link
Copy Markdown
Contributor

Overview

src/rugby.ts:

Info:

Single Scripts:

  • rugby plan list

URLs:

  • https://github.com/swiftyfinch/Rugby

@withfig-bot

Copy link
Copy Markdown
Contributor

Hello @swiftyfinch,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

@swiftyfinch

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

withfig-bot added a commit that referenced this pull request Sep 30, 2023

@grant0417 grant0417 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Quick question, did you write the spec by hand or was there some swift generator you used?

@grant0417
grant0417 merged commit c6cb29a into withfig:master Oct 12, 2023
@withfig withfig locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants