Repository navigation
Conversation
Co-authored-by: GPT-6 Codex <codex@openai.com>
Co-authored-by: GPT-6 Codex <codex@openai.com>
Co-authored-by: GPT-6 Codex <codex@openai.com>
Co-authored-by: GPT-6 Codex <codex@openai.com>
fspy benchmarklinuxmacoswindows |
Co-authored-by: GPT-6 <codex@openai.com>
Co-authored-by: GPT-6 <codex@openai.com>
Co-authored-by: GPT-6 <codex@openai.com>
This was referenced Sep 28, 2026
wan9chi
added a commit
that referenced
this pull request
Oct 5, 2026
## Motivation The self-hosted remote cache server in #718, designed in #716, serves reads to anyone but accepts a store only with a GitHub Actions OIDC token. Other servers will need other credentials. For example, a private cache behind Cloudflare Access could need headers on every request. This adds one general hook so each kind of credentials is a separate implementation, and the client doesn't need to know about any of them. ## Changes - `vt_remote_cache::auth::Auth` supplies the headers for each request, given its operation: fetch, download, or store. It can use the client's HTTP client to get credentials, such as a token, and that client doesn't follow redirects. If it fails, the request isn't sent, and the operation fails with the new `Error::Auth` ("failed to authenticate"). - `Client::new(endpoint, auth)` takes the auth. `Anonymous` adds no headers. - Planning resolves how requests authenticate into `remote_cache.auth`, next to the access mode and endpoint. The result holds everything needed to build the credentials, so nothing reads envs after planning. Choosing the auth from `cache.remote` config or envs later only changes this step. For now, the only kind is `anonymous`. - `vt` turns the resolved auth into a `vt_remote_cache` auth with `build_auth`, a single `match`, and caches clients by endpoint and auth. Requests don't change. Plan snapshots gain `"auth": {"kind": "anonymous"}`. The next PR in this stack adds GitHub Actions OIDC as the first auth with credentials. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
wan9chi
added a commit
that referenced
this pull request
Oct 5, 2026
…DC (#798) ## Motivation The self-hosted remote cache server in #718, designed in #716, accepts uploads only with a GitHub Actions OIDC token. The token's audience must be the namespace endpoint, and it must come from a push job on the main branch. `vp run` sends stores without credentials today, so that server rejects every upload with 401. ## Changes - Planning resolves `remote_cache.auth` to `github-oidc` when `ACTIONS_ID_TOKEN_REQUEST_URL` and `ACTIONS_ID_TOKEN_REQUEST_TOKEN` are set in the envs visible at the `vp run` level. That happens in jobs with `permissions: id-token: write`; otherwise the auth stays `anonymous`. - It holds the request URL, the request token, and the audience, which is the endpoint without a trailing slash. - The request token is a `Secret`, which debug output and serialized plans redact. - `build_auth` turns `github-oidc` into `vt_remote_cache::auth::GithubOidc`, which adds `Authorization: Bearer <token>` to stores only. Fetches and downloads stay anonymous. - It requests a token when the first store needs one. - Later stores reuse the token until two minutes before its `exp`. Cloudflare receives a store's whole body before the Worker checks the token, so the token has to outlast the upload. A token without `exp` is a malformed response. - Concurrent stores wait for the same request. - A failed request is remembered, so later stores fail right away without making more requests. Each task with a failed upload shows the existing "Not uploaded to the remote cache" warning. - Neither token appears in debug output or errors. - Its state is a single enum: ready with a request and an optional cached token, or failed. A token can't stay cached after a failure. - Tasks still receive the two env vars as untracked envs, as in #691, so npm trusted publishing through `vp run` keeps working. Stacked on #797, which adds the `Auth` hook and the resolved auth config. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Open-source contributors need to reuse task results without credentials. Maintainers need a low-cost service that accepts uploads from trusted GitHub Actions jobs.
Propose a self-hosted remote cache for
vp runon Cloudflare Workers, D1, and R2, based on #713. Reads are public. Writes use GitHub OIDC and require a push job on the registered repository's main branch.vp cache pushpublishes selected results explicitly.The RFC includes setup and storage diagrams, operational limits, and Free/Paid capacity estimates. Measurements from four published Vite frontends support the cache-size assumptions.