Skip to content

Metrics: Go runtime metrics (#8927) - #9281

Merged
ti-chi-bot[bot] merged 6 commits into
tikv:release-7.5from
ti-chi-bot:cherry-pick-8927-to-release-7.5
Jul 8, 2025
Merged

Metrics: Go runtime metrics (#8927)#9281
ti-chi-bot[bot] merged 6 commits into
tikv:release-7.5from
ti-chi-bot:cherry-pick-8927-to-release-7.5

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Apr 28, 2025

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #8927

What problem does this PR solve?

Issue Number: Close #8931

What is changed and how does it work?

Using promtheus clieng golang mod to expose go runtime metrics.
how to see this:

tiup playground nightly --pd.mode ms --tiflash 0 --kv 3 --pd 1 --db 1 --tso 2 --scheduling 1 --tso.binpath ./bin/pd-server --scheduling.binpath ./bin/pd-server --pd.binpath ./bin/pd-server

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

image
image

Code changes

Side effects

Related changes

Release note

expose golang runtime metrics

@bufferflies @ti-chi-bot
This is an automated cherry-pick of tikv#8927
e1382a1 
close tikv#8931

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Apr 28, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 28, 2025
Merged
@ti-chi-bot

ti-chi-bot commented Apr 28, 2025

Copy link
Copy Markdown
Member Author

@bufferflies This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@bufferflies
bufferflies force-pushed the cherry-pick-8927-to-release-7.5 branch from 0206ad6 to ee49847 Compare May 9, 2025 08:27
@bufferflies
resolve conflict
a674dc9 
Signed-off-by: 童剑 <1045931706@qq.com>
@bufferflies
bufferflies force-pushed the cherry-pick-8927-to-release-7.5 branch from ee49847 to a674dc9 Compare May 9, 2025 08:30
@bufferflies
bufferflies force-pushed the cherry-pick-8927-to-release-7.5 branch 2 times, most recently from e2ff68a to 9a89037 Compare July 4, 2025 04:07
@bufferflies
go mod tidy
8386997 
Signed-off-by: 童剑 <1045931706@qq.com>
@bufferflies
bufferflies force-pushed the cherry-pick-8927-to-release-7.5 branch from fa29bbf to 8386997 Compare July 4, 2025 04:20
@bufferflies
bufferflies force-pushed the cherry-pick-8927-to-release-7.5 branch from e9b26bd to 1e0f6cd Compare July 4, 2025 04:31
@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 4, 2025
rleungx
rleungx reviewed Jul 4, 2025
View reviewed changes
Comment thread go.mod Outdated
rleungx
rleungx reviewed Jul 4, 2025
View reviewed changes
Comment thread pkg/basicserver/metrics.go Outdated
@bufferflies
format
effecfd 
Signed-off-by: 童剑 <1045931706@qq.com>
@bufferflies
lint
95e043b 
Signed-off-by: 童剑 <1045931706@qq.com>
@bufferflies
bufferflies requested a review from rleungx July 7, 2025 02:58
@bufferflies

bufferflies commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

/retest

@ti-chi-bot

ti-chi-bot Bot commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 7, 2025
@ti-chi-bot

ti-chi-bot Bot commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

[LGTM Timeline notifier]

Timeline:

  • 2025-07-04 06:00:15.501256341 +0000 UTC m=+1633868.224435317: ☑️ agreed by lhy1024.
  • 2025-07-07 02:59:26.650939347 +0000 UTC m=+1882219.374118329: ☑️ agreed by rleungx.

@bufferflies

bufferflies commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot

ti-chi-bot Bot commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

@bufferflies: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: Proposal: Strengthen configuration change approval.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@bufferflies

bufferflies commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

/retest

@ti-chi-bot ti-chi-bot Bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 7, 2025
@bufferflies

bufferflies commented Jul 8, 2025

Copy link
Copy Markdown
Contributor

/unhold

@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2025
@ti-chi-bot
ti-chi-bot Bot merged commit de3246b into tikv:release-7.5 Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bufferflies bufferflies bufferflies left review comments
@lhy1024 lhy1024 lhy1024 approved these changes
@rleungx rleungx rleungx approved these changes

Assignees

@bufferflies bufferflies

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @bufferflies @lhy1024 @rleungx