Skip to content

config: fix trace-region-flow displayed incorrectly (#7993) - #8008

Merged
ti-chi-bot[bot] merged 2 commits into
tikv:release-6.5from
ti-chi-bot:cherry-pick-7993-to-release-6.5
Apr 1, 2024
Merged

ti-chi-bot[bot] merged 2 commits into
tikv:release-6.5from
ti-chi-bot:cherry-pick-7993-to-release-6.5

Conversation

@ti-chi-bot

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #7993

What problem does this PR solve?

Issue Number: Close #7917.

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Manual test

After this PR:

mysql> show config where name like "%pd-server.trace-region-flow%";
Empty set (0.01 sec)

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Apr 1, 2024
@ti-chi-bot

ti-chi-bot Bot commented Apr 1, 2024 •

Copy link
Copy Markdown
Contributor

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot Bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 1, 2024
@codecov

codecov Bot commented Apr 1, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.55%. Comparing base (f11bf75) to head (0c39e2f).

Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.5    #8008      +/-   ##
===============================================
+ Coverage        75.44%   75.55%   +0.10%     
===============================================
  Files              332      332              
  Lines            33827    33825       -2     
===============================================
+ Hits             25522    25556      +34     
+ Misses            6096     6062      -34     
+ Partials          2209     2207       -2     
Flag Coverage Δ
unittests 75.55% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot Bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 1, 2024
@JmPotato

JmPotato commented Apr 1, 2024

Copy link
Copy Markdown
Member

/merge

@ti-chi-bot

ti-chi-bot Bot commented Apr 1, 2024

Copy link
Copy Markdown
Contributor

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot

ti-chi-bot Bot commented Apr 1, 2024

Copy link
Copy Markdown
Contributor

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 0c39e2f

@ti-chi-bot ti-chi-bot Bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2024
@ti-chi-bot
ti-chi-bot Bot merged commit efb03ec into tikv:release-6.5 Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants