Repository navigation
Conversation
arthurschreiber
left a comment
There was a problem hiding this comment.
Thanks for this, clarifying what scale means for the temporal types is a good improvement. The request-parameter defaults described here match the code, but the bulk-load comment describes a default that bulk load never actually uses, so I'd like that fixed before merging. Details inline.
One more thing: the @param scale For Numeric, Decimal, Time, DateTime2, DateTimeOffset. line on BulkLoad#addColumn (around line 292) is unchanged, so it's now inconsistent with the new ColumnOptions.scale docs. Could you update it too, or point it at ColumnOptions.scale?
It would also help to run the typedoc build to check that the inline code and emphasis render properly with the link format from #1826. eslint alone won't catch that.
Generated by Claude Code
Summary
scalecontrols fractional-second digits for Time, DateTime2, and DateTimeOffset parameters and bulk-load columns.7, or0fornullvalues).{ scale: 3 }.The option remains named
scaleto avoid a compatibility change.Validation
npx eslint src/request.ts src/bulk-load.ts