Skip to content
This repository was archived by the owner on Oct 9, 2020. It is now read-only.
This repository was archived by the owner on Oct 9, 2020. It is now read-only.

throw exception when minifying font-awesome V4.3.0 css #39

Open

Description

@areel

Using bundle-sfx on an app that includes font-awesome.

underlying issue is probably related to
clean-css/clean-css#524.

while investigating this (I haven't read the code closely) I thought it might be useful if the css plugin checked if the file referenced was already minified. This would allow imports statements like:

import 'font-awesome/css/font-awesome.min.css!';

Aidan

Activity

  1. guybedford commented on Jun 8, 2015

    @guybedford
    Member

    Sure, I'll look into this when I can. Any suggestions are welcome too.

  2. areel commented on Jun 13, 2015

    @areel
    Author

    Took another look and the bundle command reports the same error, Bootstrap is also failing

    Steps to reproduce

    jspm init -y
    jspm install css bootstrap 
    echo "import _ from 'bootstrap/css/bootstrap.css!';" > app.js
    jspm bundle app app-build.js
    

    I tested with the latest version of clean-css(3.3.2) (we are locked on 3.1) issue remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions