Repository navigation
feat(ai-studio): the decider is offered every resume action - #213
Open
dawidaksamski wants to merge 6 commits into
Open
dawidaksamski wants to merge 6 commits into
dawidaksamski wants to merge 6 commits into
Conversation
dawidaksamski
added this pull request to stack #199
October 9, 2026 12:12
dawidaksamski
force-pushed
the
feat/WB-683-review-node-decision-ui
branch
from
October 9, 2026 13:46
a8b757e to
a0d3607
Compare
dawidaksamski
force-pushed
the
feat/WB-683-review-node-decision-ui
branch
from
October 9, 2026 13:56
a0d3607 to
a5d3da6
Compare
added 6 commits
October 9, 2026 16:05
dawidaksamski
force-pushed
the
feat/WB-683-review-node-decision-ui
branch
from
October 9, 2026 14:05
a5d3da6 to
ba25adb
Compare
dawidaksamski
marked this pull request as ready for review
October 9, 2026 14:10
dawidaksamski
requested review from
librowski,
lukasz-jazwa,
piotrblaszczyk and
szymon-t-sc
as code owners
October 9, 2026 14:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The decider's form offers every
resumeaction of a decision request, not only the first. On a Review node the panel footer reads "Reject…", "Escalate…", "Approve", so Escalate can now be chosen from the UI.offeredActionsreturns every resume action in the request's order, plus the optional reject. Its other rules are unchanged: arerun-sourceaction is still left out, a blank label still falls back to the name, and a request with no usable resume action offers nothing.action-dialog.tsx, which both flows share. The dialog state is keyed by action name, because the request is read again on every render and names are unique within it.DecisionInputandDecisionDraftgaincomment. The submit adapter sends it only when it has text.readDecisionOutcomereads it back, treating a blank comment as none.The comment is required by the editor only. The contract leaves it optional, so the backend still accepts an escalate without a comment through the API. Enforcing it there is separate work (
follow-up: decision-resume-reason-required).Docs
Not in this PR
Testing
{ action: 'escalate', edits, comment }and closing the dialog;completedwith no outcome.