Repository navigation
fix(verify): preserve custom scheme in PKCE redirects - #2865
Open
Tyagiquamar wants to merge 1 commit into
Open
Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
Avoid re-serializing bare custom-scheme redirect URIs through url.URL, which drops the authority marker and corrupts PKCE auth codes on iOS. Fixes supabase#2423
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
myapp://) when appending the PKCE auth code query parameter.url.URLre-serialization dropping the//authority marker, which corrupted auth codes on iOS native clients.Test plan
docker run --rm -v D:/pers/open source/supabase-auth:/work -w /work golang:1.27-bookworm go test ./internal/api/ -run TestPrepPKCERedirectURLCustomScheme -count=1(exit 0, ok in 0.280s after compile)docker run ... gofmt -l internal/api/verify.go internal/api/verify_test.go(no output, exit 0)Fixes #2423