Skip to content

chore: updated the dependencies for the example app - #657

Merged
acomley-stripe merged 1 commit into
masterfrom
acomley/run-dx-537
Oct 19, 2021
Merged

acomley-stripe merged 1 commit into
masterfrom
acomley/run-dx-537

Conversation

@acomley-stripe

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread example/ios/Podfile.lock
PODFILE CHECKSUM: 32acfd4fec652a6f224d467187287782155cfbdc

COCOAPODS: 1.10.2
COCOAPODS: 1.11.2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@porter-stripe porter-stripe Oct 19, 2021 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI appears to be using 1.11.2. I don't think it makes much of a difference between 1.10.2 and 1.11.2, but it may be nice to introduce a Gemfile so we can specify what Cocoapods version we expect to be used. Doesn't need to be done in this PR.

https://guides.cocoapods.org/using/a-gemfile.html

https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I'll take care of this in a future PR.

@acomley-stripe
acomley-stripe merged commit 4043f79 into master Oct 19, 2021
@acomley-stripe
acomley-stripe deleted the acomley/run-dx-537 branch October 19, 2021 18:31

@Cordelro86 Cordelro86 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants