Repository navigation
fix: removing usage of the map for cardview reference - #436
Merged
Merged
Conversation
arekkubaczkowski
approved these changes
Jul 21, 2021
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to fix #391
In order to fix the deallocation issue and make the code a little bit more readable I moved the CardFieldView reference from manager to StripeSdk. Thanks to that we don't have to cache anything in ViewManager and accessing card reference is easier from StripeSdk.
This solution works with assumption that there can only be one CardField rendered at once
TODO:
closes #391