Repository navigation
Conversation
jaygeorge
reviewed
Oct 19, 2026
|
|
||
| */ | ||
| @utility bg-architectural-lines { | ||
| &:not(:has(.page-tree-branch)) { |
Contributor
There was a problem hiding this comment.
This one's fine to drop, now that #15681 is in. The navigation page wasn't removing the class when you left, so after visiting an empty nav the lines would show up on other pages. The :has(.page-tree-branch) guard was quietly hiding that behind the Pages tree. With #15681 the class doesn't leak any more, so the guard isn't needed.
Contributor
Author
There was a problem hiding this comment.
Thanks! Rebased onto 6.x so #15681 is included :)
o1y
force-pushed
the
cp-perf-small-fixes
branch
from
October 19, 2026 18:56
4de0216 to
6e87d91
Compare
jaygeorge
reviewed
Oct 20, 2026
| } | ||
| /* =Jay. Exceptions */ | ||
| /* e.g. for a fieldset, we don't want to trim the text when we have a label like on a collections field, Link Item button */ | ||
| .form-group :has(> &) & { |
Contributor
There was a problem hiding this comment.
✔ confirmed this has no negative effect
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On large entries the CP is really slow for us. Most of the time went into Chrome recalculating styles. Here are two small changes that helped:
Page load went from ~11.5s to ~1.3s and opening Live Preview from ~10.5s to ~1.5s for us.
Please treat this as a suggestion rather than a fully tested implementation. I only checked it on our setup in Chrome. There are a still a few other rules with the same pattern (e.g. in base.css and Header.vue) that might be worth a look too. In general I would avoid has on body or any other big container.