Repository navigation
Conversation
When ignoreWarnings is disabled and the statement reports a warning, JdbcTemplate.execute throws SQLWarningException after the stream callback has acquired the ResultSet. Since queryForStream executes with closeResources=false and the Stream is never returned, the ResultSet, Statement and Connection were leaked. Close the stream (and thereby its resources) in that case. Signed-off-by: lejuho <zedd1324@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
queryForStream runs with
closeResources=falseand hands cleanup to the returned Stream's close handler. However,handleWarningsis invoked after the Stream has been created; withignoreWarnings=falseand a statement warning present, it throwsSQLWarningException(a RuntimeException) which bypasses thecatch (SQLException)cleanup. Since the Stream never reaches the caller, the ResultSet, Statement and Connection are leaked. This also affects NamedParameterJdbcTemplate and JdbcClient streams.This change closes the Stream (releasing all resources) if warning handling fails, for both the Statement and PreparedStatement paths. The
closeResourcescontract is unchanged. Regression tests cover both paths.