Skip to content

chore(audits): name generated-artifact checks check:<x> so run-audits discovers them - #8882

Merged
waleedlatif1 merged 2 commits into
stagingfrom
chore/audit-script-names
Oct 10, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
chore/audit-script-names

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Rename the generated-artifact checks tool-metadata, deployment-config, integration-catalog, docs, agent-stream-docs and docs-manifest to check:<x>. Their generators become generate:<x>, the same pattern as the existing generate:openapi / check:openapi pair.
  • run-audits now finds every audit by its check:* prefix. The hand-kept EXTRA_AUDITS list is deleted.
  • check:docs-manifest now runs inside check:audits, so its separate CI step and its line in the CLAUDE.md gate are removed. It reads only the local filesystem and takes about 1s.
  • The <x>:check suffix remains only on checks this job can't run: the mothership contracts (they need the sibling repo), images:check (needs Helm) and library:covers:check (output differs per machine). The run-audits header documents this.
  • Add headers to check-monorepo-boundaries, check-realtime-prune-graph and check-openapi saying what each protects and how to fix a finding.

Every reference is updated: package.json, workflows, skills, rules, generated-file headers and generator error messages. git grep finds no remaining old names.

Test plan

  • CI Repo audits runs the renamed checks, check:docs-manifest included
  • publish-sim-setup workflow resolves check:deployment-config

… discovers them

Rename tool-metadata, deployment-config, integration-catalog, docs, agent-stream-docs
and docs-manifest checks to check:<x> (generators to generate:<x>, matching the
existing generate:openapi/check:openapi pairs). run-audits now derives every audit
from the check:* prefix, so the hand-kept EXTRA_AUDITS list is gone, and
check:docs-manifest (local fs only, ~1s) joins check:audits instead of its own CI
step and CLAUDE.md gate line. The <x>:check suffix stays only for checks this job
cannot run (sibling copilot repo, Helm, per-machine covers).

Add module headers to check-monorepo-boundaries, check-realtime-prune-graph and
check-openapi saying what each protects and how to fix a finding.
@waleedlatif1
waleedlatif1 requested a review from a team as a code owner October 10, 2026 04:53
@vercel

vercel Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 10, 2026 5:08am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 36 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable new issues were found.

Summary

Renames generated-file checks to check:<x> so check:audits discovers them without a separate list.

  • Generated-artifact checks now join audits through their names.
  • Three audit scripts explain their rules and how to fix findings.

Review history: no previous findings were supplied, and GitHub thread history could not be retrieved.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[CI Repo audits] --> B[check:audits]
  B --> C[Discover check:* scripts]
  C --> D[Skip explicitly excluded checks]
  D --> E[Run checks concurrently]
  E --> F[Include generated-file checks and docs manifest]
  F --> G[Fail if any check fails]
Loading

Reviews (2) · Last reviewed commit: "docs(ship): regenerate tool metadata in ..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 36 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit b3f459d into staging Oct 10, 2026
56 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/audit-script-names branch October 10, 2026 19:36

This branch was successfully deployed

1 active deployment
Preview — 98689a0c Deployed Oct 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant