Repository navigation
chore(audits): name generated-artifact checks check:<x> so run-audits discovers them - #8882
Merged
Merged
Conversation
… discovers them Rename tool-metadata, deployment-config, integration-catalog, docs, agent-stream-docs and docs-manifest checks to check:<x> (generators to generate:<x>, matching the existing generate:openapi/check:openapi pairs). run-audits now derives every audit from the check:* prefix, so the hand-kept EXTRA_AUDITS list is gone, and check:docs-manifest (local fs only, ~1s) joins check:audits instead of its own CI step and CLAUDE.md gate line. The <x>:check suffix stays only for checks this job cannot run (sibling copilot repo, Helm, per-machine covers). Add module headers to check-monorepo-boundaries, check-realtime-prune-graph and check-openapi saying what each protects and how to fix a finding.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
…comment with no command
2 tasks
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool-metadata,deployment-config,integration-catalog,docs,agent-stream-docsanddocs-manifesttocheck:<x>. Their generators becomegenerate:<x>, the same pattern as the existinggenerate:openapi/check:openapipair.run-auditsnow finds every audit by itscheck:*prefix. The hand-keptEXTRA_AUDITSlist is deleted.check:docs-manifestnow runs insidecheck:audits, so its separate CI step and its line in the CLAUDE.md gate are removed. It reads only the local filesystem and takes about 1s.<x>:checksuffix remains only on checks this job can't run: the mothership contracts (they need the sibling repo),images:check(needs Helm) andlibrary:covers:check(output differs per machine). Therun-auditsheader documents this.check-monorepo-boundaries,check-realtime-prune-graphandcheck-openapisaying what each protects and how to fix a finding.Every reference is updated: package.json, workflows, skills, rules, generated-file headers and generator error messages.
git grepfinds no remaining old names.Test plan
Repo auditsruns the renamed checks,check:docs-manifestincludedpublish-sim-setupworkflow resolvescheck:deployment-config