Repository navigation
chore(audits): drop dead ESLint directives and redundant check:dead-code; fix the PPTX blend-group call they hid - #8876
Conversation
…ad-code script - Remove all 89 `eslint-disable` comments. Nothing runs ESLint (no eslint dependency or config in any workspace; Next 16 `next build` has no lint step), so they suppressed nothing. Reasons they carried are kept as plain `//` whys. - `check:comment-hygiene` now rejects `eslint-disable`/`eslint-enable` comments so they cannot return. - Remove `check:dead-code`: `check:unused-exports` already runs knip with the same config and a superset of its issue types, and `check:audits` skipped the alias. - Ignore unused exports in the generated `apps/docs/components/icons.tsx` (a verbatim copy of the sim icon set, whose export surface is ratcheted at the source) and shrink the unused-exports baseline by its 66 entries.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
All reported issues were addressed across 48 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
eslint-disable/eslint-enablecomments. Nothing runs ESLint (no eslint package or config in any workspace, every lint script is Biome, andnext build16.4 has no lint step), so they suppressed nothing and implied rules that don't exist. Where a directive carried a reason, the reason stays as a plain//whycheck:comment-hygienenow rejects ESLint directives, so they can't come back (two cases added to its existing test file; the flagging case fails against the old script)svg.appendChild(group)(path as any).__rectBlendGroup = undefinedcalled the appended element as a function and threw whenever a rect gradient blend group existed. Split into the two statements it was meant to becheck:dead-code:check:unused-exportsalready runs knip with the same config and a superset of issue types, andcheck:auditsalready skipped the alias. The knip config staysapps/docs/components/icons.tsx(a verbatim copy written bygenerate-docs.ts) in knip; its export surface is already ratcheted at the source file. The unused-exports baseline shrinks by 66 entriesyou-might-not-need-a-commentskill updated to matchType of Change
Testing
check:comment-hygiene(passes; flags all 89 directives on staging), its test file (10/10), andcheck:unused-exports(passes with the shrunk baseline);biome checkon every changed fileChecklist