Repository navigation
fix(lint): describe unquoted JSON references as failing only when the text is not itself JSON - #8854
Merged
Merged
Conversation
… text is not itself JSON
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unquoted-json-stringfindings as references that "will not work as written", which overstates them: a text output inserted raw is still valid JSON when its runtime value is itself JSON (true,42, an object).unknown-fieldand missing-block findings keep the unconditional wording, since those always fail.apps/docs/openapi-v2-workflows.jsonfrom the contract.Type of Change
Testing
generate:openapi,check:openapi,check:cli-docs(no CLI docs change),docs:checkbun run lint,check:audits(58),type-check,docs-manifest:checkbun run test: two timing-sensitive tests in unrelated files (html-parser.test.ts,remark-plain-text.test.ts) failed under full-suite load and pass in isolationChecklist
test-auditauthoring gate)