Skip to content

fix(lint): describe unquoted JSON references as failing only when the text is not itself JSON - #8854

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/lint-unquoted-json-wording
Oct 9, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/lint-unquoted-json-wording

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • The v2 workflow lint contract described unquoted-json-string findings as references that "will not work as written", which overstates them: a text output inserted raw is still valid JSON when its runtime value is itself JSON (true, 42, an object).
  • The description now says these leave the field invalid JSON at run time unless the text is itself JSON, matching the lint reason the deploy warning and the agent already see. unknown-field and missing-block findings keep the unconditional wording, since those always fail.
  • Regenerated apps/docs/openapi-v2-workflows.json from the contract.

Type of Change

  • Bug fix (docs/contract wording)

Testing

  • generate:openapi, check:openapi, check:cli-docs (no CLI docs change), docs:check
  • bun run lint, check:audits (58), type-check, docs-manifest:check
  • Root bun run test: two timing-sensitive tests in unrelated files (html-parser.test.ts, remark-plain-text.test.ts) failed under full-suite load and pass in isolation

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 9, 2026 5:10pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low impact] This wording-only change appears safe to merge.

Summary

Clarifies that unquoted text references can leave JSON fields invalid unless the inserted text is itself JSON.

  • Updates the workflow contract description and its generated OpenAPI copy together.
  • Leaves lint checks, response shapes, and runtime behavior unchanged.
  • No actionable issues found.

Reviews (1) · Last reviewed commit: "fix(lint): describe unquoted JSON refere..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit c3c3d56 into staging Oct 9, 2026
47 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/lint-unquoted-json-wording branch October 9, 2026 17:33

This branch was successfully deployed

1 active deployment
Preview — 35cc2eaa Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant