Skip to content

improvement(emcn): refine shared menu and picker styling - #8836

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/refine-menu-surfaces
Oct 9, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/refine-menu-surfaces

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Refine dropdowns, picker lists, and popovers with shared menu styles while preserving comfortable 28px rows and existing chip geometry and color tokens.
  • Align search fields, separators, elevation, and selection checks across chip pickers, date/time popovers, breadcrumb menus, and table-view menus.
  • Remove consumer chrome overrides and update component guidance to document the shared tokens.

Type of Change

  • Improvement

Testing

  • Cleanup: effects, state, memo, callback, React Query, URL-state, EMCN design, and comment passes.
  • bun run --cwd packages/emcn test and root bun run test.
  • bun run lint, bun run type-check, bun run check:audits, bun run docs-manifest:check, and the block-registry check against origin/staging.
  • Regenerated documentation manifests, agent documentation, and skill mirrors; verified workflows with actionlint 1.7.12.
  • Checked the component preview in light/dark mode, including search, keyboard selection, grouped options, and multi-select.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1
waleedlatif1 requested a review from a team as a code owner October 9, 2026 05:04
@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 9, 2026 5:10am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 14 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

This PR brings menus, picker lists, and popovers onto shared MENU_STYLES tokens.

  • Aligns surfaces, search fields, headings, separators, and selection checks.
  • Removes local styling overrides from breadcrumb and table-view menus.
  • Adds private imports for shared tokens and updates component guidance.
  • No actionable issues were found in the reviewed changes.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  C["Chip tokens"] --> M["MENU_STYLES"]
  M --> D["DropdownMenu"]
  M --> P["Popover"]
  M --> B["Combobox"]
  M --> S["Chip pickers"]
  P --> V["Breadcrumb and view menus"]
  P --> T["TimePicker"]
Loading

Reviews (1) · Last reviewed commit: "improvement(emcn): refine shared menu an..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit e89bc65 into staging Oct 9, 2026
39 of 40 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/refine-menu-surfaces branch October 9, 2026 05:10

This branch was successfully deployed

1 active deployment
Preview — 599880ae Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant