Skip to content

fix(mcp): publish connector metadata and directory verification - #8832

Closed
waleedlatif1 wants to merge 2 commits into
mainfrom
codex/claude-connector-production
Closed

waleedlatif1 wants to merge 2 commits into
mainfrom
codex/claude-connector-production

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Publish MCP request-body object schemas and complete tool annotations so connector clients receive usable metadata.
  • Serve the public directory ownership challenge on the dedicated MCP host for automated clients while keeping unrelated app routes blocked.
  • Include HTTP coverage for the challenge response, headers, and host isolation, with a JSON report in CI.

Type of Change

  • Bug fix

Testing

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (combined production CI pending)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 9, 2026 2:22am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge based on the reviewed changes.

Summary

This PR publishes MCP body schemas and tool annotations, adds the public ownership challenge, and lets automated clients reach it on the dedicated MCP host.

  • Other app routes remain blocked on the dedicated host.
  • The new HTTP suite checks the challenge body, headers, and host isolation, then writes a JSON report for CI.
  • No actionable new issues were found. No previous review threads were supplied.
  • Review checks were based on source inspection; tests were not run.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Client[Client on dedicated MCP host] --> Proxy[Check request path]
  Proxy -->|Exact ownership challenge path| Challenge[Return public token]
  Proxy -->|Canonical MCP path| MCP[MCP server]
  Proxy -->|OAuth metadata path| Metadata[Return discovery metadata]
  Proxy -->|Other paths| Reject[Return 404]
Loading

Reviews (2) · Last reviewed commit: "fix(mcp): add directory verification com..." · Reviewed by Greptile

* fix(mcp): add directory verification compatibility

* test(mcp): verify ownership challenge over HTTP
@waleedlatif1 waleedlatif1 changed the title fix(mcp): declare request bodies and annotation titles fix(mcp): publish connector metadata and directory verification Oct 9, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 deleted the codex/claude-connector-production branch October 9, 2026 04:08

This branch was successfully deployed

1 active deployment
Preview — 2ed28eed Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant