feat(files): add the Project file backend and APIs by mzxchandra · Pull Request #8610 · simstudioai/sim

mzxchandra · 2026-10-04T12:50:28Z

Summary

Add the complete Project-file backend: folders, uploads, edits, history, copy, recursive listing/downloads, extraction, search, compiled documents, sharing and realtime persistence callbacks.
Reuse authorized application operations across sessions, v2/CLI and delegated callers. Writes require an organization admin, an admin in an active environment, or write access in every active environment; workspace API keys do not acquire Project authority.
Preserve canonical ownership and revision checks through storage, history, billing, retention, cross-owner copies and content delivery. Public/password/email/SSO sharing rechecks current policy and dependencies.
Keep Project operations behind the existing release gates. Execution files remain workspace scoped; chat ownership remains personal/organization scoped.

Stacked on #8609 above #8590, with #8762 as the lifecycle prerequisite. This PR contains the backend, HTTP API, CLI, documentation and the public-share viewer required for content delivery. Stacked #8781 adds authenticated Project Files UI, picker/mentions and Sim-side Mothership integration; Mothership #594 is its separate worker companion. No additional migration is introduced here.

Type of Change

New feature

Testing

Integrated backend: 263 real-Postgres checks and 84 live HTTP checks across authorization, browser queries, history, sharing, rendering, copying and realtime.
Four additional HTTP checks verify recursive pagination, unchanged root browsing, cursor scope binding and rejection of conflicting folder filters.
Full backend root suite previously passed all 19 workspace tasks; the latest bounded route change passes formatting and all 58 repository audits. Full-repository checks for the published head run in CI.
Fresh migration/replay/schema-drift, generated artifacts and backend contract checks passed. Live paired product/worker acceptance additionally verifies the backend through actual model read/write/copy and browser delivery.
CI is manually dispatched for the stacked branch; workflow triggers and timeouts are unchanged.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Relevant tests updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-10-04T12:50:35Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Oct 8, 2026 7:17pm UTC

mzxchandra · 2026-10-06T00:31:12Z

@greptile

mzxchandra · 2026-10-06T00:31:15Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-06T00:31:20Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 485 files

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.

Re-trigger cubic}

Reuse entity-owned file operations across Project UI, session APIs, v2/CLI, and delegated Mothership callers. Add Project discovery, sharing, history, copy, collaborative editing, and current-access invalidation while preserving workspace execution boundaries and independent creator/payer attribution. Keep activation gated behind the file-ownership compatibility foundation. Run real HTTP suites through disposable fixture orchestration in CI.

greptile-apps · 2026-10-06T00:39:34Z

Confidence Score: 5/5

[Critical impact] The PR appears safe to merge based on the reviewed changes and resolved prior findings.

Summary

The PR adds Project-file storage and application operations, HTTP and v2 APIs, CLI commands, public delivery, and realtime file-list support.

The changes since the previous review replace single-owner invalidation-room joins with independent per-owner subscriptions and update their tests.
All five previous Greptile threads are resolved; no new actionable finding was established.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Client[Browser or CLI] --> API[Project file APIs]
  API --> Ops[Authorized file operations]
  Ops --> Data[File metadata and storage]
  Ops --> Relay[Realtime invalidation]
  Relay --> Viewers[Subscribed viewers refetch]
  Share[Public share request] --> Grant[Current share policy]
  Grant --> Data

_{Reviews (11) · Last reviewed commit: "fix(realtime): preserve concurrent owner..." · Reviewed by Greptile}

mzxchandra · 2026-10-06T00:46:17Z

@greptile

mzxchandra · 2026-10-06T00:46:19Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-06T00:46:23Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 485 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.

Re-trigger cubic}

mzxchandra · 2026-10-08T07:06:55Z

@greptile

mzxchandra · 2026-10-08T07:06:56Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-08T07:07:03Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

1 issue found across 389 files

Confidence score: 4/5

In apps/sim/lib/workspace-files/api/archive-presenter.ts, canceling while downloadFileStream() is pending can leave the storage stream open once it resolves. Ensure that stream is destroyed on this cancellation path.

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/lib/workspace-files/api/archive-presenter.ts">

<violation number="1" location="apps/sim/lib/workspace-files/api/archive-presenter.ts:44">
P2: Canceling the archive while `downloadFileStream()` is pending destroys the wrapper before this generator enters its `try/finally`, leaving the subsequently opened storage stream undestroyed. Arrange to destroy a stream if acquisition resolves after `closed` aborts.</violation>
</file>

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

…essions

…ounting

mzxchandra · 2026-10-08T08:03:38Z

@greptile

mzxchandra · 2026-10-08T08:03:39Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-08T08:03:45Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 389 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

mzxchandra · 2026-10-08T08:12:45Z

Regarding “Project admins can be denied”: this scenario is excluded by the current database invariant. The member schema defines member_user_id_unique on member.userId. Migration 0136 creates that UNIQUE index, and no later SQL migration drops it. Each user therefore has at most one membership row, so limit(1) cannot choose a different row among multiple organization memberships. The admin predicate also requires an exact match to the canonical Project organization before checking the role. No authorization change is needed while this invariant holds.

mzxchandra · 2026-10-08T17:41:16Z

@greptile

mzxchandra · 2026-10-08T17:41:18Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-08T17:41:25Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 390 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

mzxchandra · 2026-10-08T19:17:55Z

@greptile

mzxchandra · 2026-10-08T19:17:56Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-08T19:18:03Z

@cubic-dev-ai review this PR

@mzxchandra I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 391 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

mzxchandra mentioned this pull request Oct 4, 2026

feat: establish shared file ownership foundation #8609

Draft

6 tasks done

vercel Bot deployed to Preview October 4, 2026 12:52 View deployment

mzxchandra mentioned this pull request Oct 5, 2026

feat(projects): backfill and enforce membership in SQL #8590

Open

7 tasks done

mzxchandra added this pull request to stack #8630 October 5, 2026 18:24

mzxchandra force-pushed the codex/project-files branch from 9dae237 to 3db7e57 Compare October 5, 2026 21:02

vercel Bot deployed to Preview October 5, 2026 21:04 View deployment

vercel Bot deployed to Preview October 5, 2026 22:14 View deployment

vercel Bot temporarily deployed to Preview October 5, 2026 22:42 Inactive

vercel Bot temporarily deployed to Preview October 5, 2026 23:29 Inactive

vercel Bot deployed to Preview October 6, 2026 00:33 View deployment

cubic-dev-ai Bot reviewed Oct 6, 2026

View reviewed changes

mzxchandra added 6 commits October 5, 2026 17:39

refactor: use explicit Project file ownership storage

0985191

refactor: carry file owners through collaborative documents

4f45fa6

refactor: consolidate background file retention by owner

8de6b11

fix(files): close retention races and preserve browser navigation

845b9c5

fix(files): require explicit owners in live documents

a9fd086

greptile-apps Bot reviewed Oct 6, 2026

View reviewed changes

Comment thread apps/sim/lib/projects/files/application/authorization.ts Outdated

Comment thread apps/sim/app/workspace/[workspaceId]/files/project-files.tsx Outdated

mzxchandra force-pushed the codex/project-files branch from 547eb7b to a9fd086 Compare October 6, 2026 00:44

vercel Bot deployed to Preview October 6, 2026 00:46 View deployment

cubic-dev-ai Bot reviewed Oct 6, 2026

View reviewed changes

greptile-apps Bot reviewed Oct 8, 2026

View reviewed changes

Comment thread apps/sim/lib/projects/files/application/artifacts.ts

cubic-dev-ai Bot reviewed Oct 8, 2026

View reviewed changes

Comment thread apps/sim/lib/uploads/server/image-derivative.ts

Comment thread apps/sim/lib/workspace-files/api/archive-presenter.ts Outdated

mzxchandra added 4 commits October 8, 2026 00:41

fix(files): close late archive streams and stage preview cleanup regr…

4182ed8

…essions

fix(files): integrate lifecycle history correction through shared acc…

0331957

…ounting

fix(files): clean failed Project preview derivatives

65d481b

fix(files): integrate restore compatibility correction

dcdc501

cubic-dev-ai Bot reviewed Oct 8, 2026

View reviewed changes

vercel Bot deployed to Preview October 8, 2026 08:06 View deployment

mzxchandra added 4 commits October 8, 2026 10:15

fix(files): integrate staged cleanup at workspace transaction boundaries

a03549d

fix(files): preserve Project resources after uncertain commits

0632de3

Merge foundation commit-rejection cleanup correction

804d2da

fix(files): clean Project bytes after proven commit rejection

9aed0f6

vercel Bot deployed to Preview October 8, 2026 17:42 View deployment

cubic-dev-ai Bot reviewed Oct 8, 2026

View reviewed changes

fix(realtime): preserve concurrent owner invalidation subscriptions

ebfa1c3

vercel Bot temporarily deployed to Preview October 8, 2026 19:17 Inactive

cubic-dev-ai Bot reviewed Oct 8, 2026

View reviewed changes

Conversation

mzxchandra commented Oct 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Oct 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mzxchandra commented Oct 6, 2026

Uh oh!

mzxchandra commented Oct 6, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 6, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Diagram

Uh oh!

Uh oh!

Uh oh!

mzxchandra commented Oct 6, 2026

Uh oh!

mzxchandra commented Oct 6, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 6, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

mzxchandra commented Oct 8, 2026

Uh oh!

mzxchandra commented Oct 8, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 8, 2026

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mzxchandra commented Oct 8, 2026

Uh oh!

mzxchandra commented Oct 8, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 8, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

mzxchandra commented Oct 8, 2026

Uh oh!

mzxchandra commented Oct 8, 2026

Uh oh!

mzxchandra commented Oct 8, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 8, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

mzxchandra commented Oct 4, 2026 •

edited

Loading

vercel Bot commented Oct 4, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Oct 6, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading