fix(desktop-browser): ask the user before a page's alert, confirm, or leave-site prompt is answered by waleedlatif1 · Pull Request #8432 · simstudioai/sim

waleedlatif1 · 2026-09-29T21:01:39Z

Summary

Let users answer alerts and confirmations on their visible browser page through a single native Electron dialog. Preserve the complete website message and restore keyboard focus after dismissal.
Prevent automation and Stop from answering a dialog owned by the user. Agent actions, unclaimed tabs, hidden pages, and older renderers retain their existing automatic behavior.
Ask before browser-chrome navigation discards a draft. Stay is the default, Escape keeps the draft, and Leave replays the navigation once. Clear stale decisions after navigation or a renderer crash.
Keep the renderer modal limited to the leave-page decision, using the existing shared modal and browser focus lifecycle.

Type of Change

Bug fix

Testing

All 1,070 desktop tests, 41 browser/store tests, all workspace type checks, lint, all 58 audits, docs-manifest, and block-registry checks pass. Both full repository test shards pass in CI.
Real Electron coverage exercises renderer compatibility, user/agent ownership, complete dialog messages, automation cancellation, unsaved drafts, stale decisions, and hidden pages. Reports support DESKTOP_BROWSER_DIALOGS_REPORT_PATH.
Isolated macOS CI: 91 Electron E2E tests passed (15 environment-specific skips), including browser dialogs, keyboard focus, themed shell dialogs, and password autofill. All 12 real Sim desktop E2E cases passed, along with universal packaging and packaged smoke tests.
Physical macOS QA reproduced lost keyboard focus before the fix and verified typing after native alert dismissal and confirmation cancellation with the fix.
Electron currently resolves a CDP dialog answer without necessarily closing its native sheet. The unchanged agent/fallback path retains that upstream limitation; the new user path lets Electron own both the answer and physical dismissal.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-09-29T21:01:46Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Oct 9, 2026 12:21am UTC

cubic-dev-ai

All reported issues were addressed across 8 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

waleedlatif1 · 2026-09-29T21:08:03Z

@greptile

waleedlatif1 · 2026-09-29T21:08:04Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-29T21:08:11Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

greptile-apps · 2026-09-29T21:09:52Z

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge based on the reviewed changes; no outstanding finding was established.

Summary

The PR gives users control of dialogs on their visible browser page: Electron presents alerts and confirmations, while the renderer asks whether to leave a page with unsaved changes. Agent-owned and hidden-page dialogs retain automatic handling, with end-to-end coverage for ownership and navigation decisions.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Page opens dialog] --> B{Visible user-owned page?}
  B -- No --> C[Shell answers automatically]
  B -- Yes: alert or confirm --> D[Electron native dialog]
  B -- Yes: beforeunload --> E[Renderer asks Stay or Leave]
  E -- Stay --> F[Keep page]
  E -- Leave --> G[Replay navigation once]

_{Reviews (5) · Last reviewed commit: "fix(desktop-browser): preserve native di..." · Reviewed by Greptile}

cubic-dev-ai

No issues found across 8 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

waleedlatif1 · 2026-09-29T21:29:54Z

@greptile

waleedlatif1 · 2026-09-29T21:29:55Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-29T21:30:01Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 8 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

waleedlatif1 · 2026-09-30T01:33:48Z

@greptile

waleedlatif1 · 2026-09-30T01:33:49Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-30T01:33:54Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 8 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

… leave-site prompt is answered

…ever the agent's

…over reload leave prompts

…ocus

waleedlatif1 · 2026-10-09T00:21:40Z

@greptile

waleedlatif1 · 2026-10-09T00:21:41Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-09T00:21:46Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 9 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

cubic-dev-ai Bot reviewed Sep 29, 2026

View reviewed changes

Comment thread ...s/mothership-view/components/resource-content/components/browser-session/browser-session.tsx

Comment thread apps/desktop/src/main/browser-agent/session.ts Outdated

vercel Bot temporarily deployed to Preview September 29, 2026 21:07 Inactive

greptile-apps Bot reviewed Sep 29, 2026

View reviewed changes

Comment thread apps/desktop/src/main/browser-agent/session.ts Outdated

Comment thread apps/desktop/e2e/browser-page-dialogs.spec.ts Outdated

Comment thread apps/desktop/src/main/browser-agent/session.ts

cubic-dev-ai Bot reviewed Sep 29, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 29, 2026

View reviewed changes

Comment thread apps/desktop/src/main/browser-agent/session.ts Outdated

Comment thread apps/desktop/src/main/browser-agent/session.ts Outdated

Comment thread apps/desktop/e2e/browser-page-dialogs.spec.ts Outdated

vercel Bot temporarily deployed to Preview September 29, 2026 21:29 Inactive

cubic-dev-ai Bot reviewed Sep 29, 2026

View reviewed changes

waleedlatif1 force-pushed the fix/browser-page-dialogs branch from cb2fcc6 to ce07a73 Compare September 30, 2026 01:33

vercel Bot temporarily deployed to Preview September 30, 2026 01:33 Inactive

cubic-dev-ai Bot reviewed Sep 30, 2026

View reviewed changes

Comment thread apps/desktop/src/main/browser-agent/session.ts

waleedlatif1 mentioned this pull request Oct 6, 2026

feat(desktop): keep the machine awake for background chats and yield the page to the user #8671

Merged

3 tasks done

waleedlatif1 added 4 commits October 8, 2026 17:03

fix(desktop-browser): ask the user before a page's alert, confirm, or…

be9ba65

… leave-site prompt is answered

fix(desktop-browser): ask only about the user's own on-screen page, n…

1a4ef00

…ever the agent's

fix(desktop-browser): label frame dialogs with their own origin and c…

464ed21

…over reload leave prompts

fix(desktop-browser): preserve native dialog ownership and keyboard f…

41040be

…ocus

waleedlatif1 force-pushed the fix/browser-page-dialogs branch from ce07a73 to 41040be Compare October 9, 2026 00:21

vercel Bot temporarily deployed to Preview October 9, 2026 00:21 Inactive

cubic-dev-ai Bot reviewed Oct 9, 2026

View reviewed changes

waleedlatif1 merged commit 51cdbe6 into staging Oct 9, 2026
52 of 53 checks passed

waleedlatif1 deleted the fix/browser-page-dialogs branch October 9, 2026 00:54

waleedlatif1 mentioned this pull request Oct 9, 2026

v0.9.17: tables ledger, oracle integrations, mship improvements #8853

Merged

Conversation

waleedlatif1 commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 29, 2026

Uh oh!

waleedlatif1 commented Sep 29, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 29, 2026

Uh oh!

greptile-apps Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Diagram

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 29, 2026

Uh oh!

waleedlatif1 commented Sep 29, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 29, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Sep 30, 2026

Uh oh!

waleedlatif1 commented Sep 30, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 30, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

waleedlatif1 commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 9, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Sep 29, 2026 •

edited

Loading

vercel Bot commented Sep 29, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Sep 29, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading