Repository navigation
cargotest: update xsv libc for RISC-V - #164419
Merged
rust-bors[bot] merged 1 commit intoOct 16, 2026
Merged
Conversation
Collaborator
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
jieyouxu
approved these changes
Oct 16, 2026
Contributor
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 16, 2026
…uwer Rollup of 8 pull requests Successful merges: - #162467 (handle trait solver overflow in `codegen_select_candidate`) - #164111 (Fix: Construct byte string valtree array type using literal length) - #164227 (refine: respect recursion limit in RPITIT collector to prevent stack overflow) - #164279 (Make the `documentation` scope a sub-scope of the `object` scope) - #164353 (Update LoongArch64 Linux dist builder to LLVM 23) - #164365 (Avoid erased region on transmutability) - #164419 (cargotest: update xsv libc for RISC-V) - #164422 (Implement after-stack-frame-init-hook)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 16, 2026
Rollup merge of #164419 - HNO3Miracle:fix/cargotest-xsv-riscv-libc, r=jieyouxu cargotest: update xsv libc for RISC-V Fixes #164339. The xsv repository pinned by `cargotest` has a lockfile from 2018 that uses `libc 0.2.43`. That version fails to compile on RISC-V because it does not define `c_char` for the target. Add a `cargotest` lockfile for xsv with only `libc` updated to `0.2.190` and use the existing lockfile override mechanism. This keeps xsv and its other dependencies at their current pinned versions. Tests: - `cargo update -p libc --precise 0.2.190` in the pinned xsv checkout - `cargo check --target riscv64gc-unknown-linux-gnu --tests` in xsv - `cargotest <cargo> <out-dir> xsv` (394 selected tests passed on x86_64) The full test suite has not been run on RISC-V hardware.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164339.
The xsv repository pinned by
cargotesthas a lockfile from 2018 that useslibc 0.2.43. That version fails to compile on RISC-V because it does notdefine
c_charfor the target. Add acargotestlockfile for xsv with onlylibcupdated to0.2.190and use the existing lockfile override mechanism.This keeps xsv and its other dependencies at their current pinned versions.
Tests:
cargo update -p libc --precise 0.2.190in the pinned xsv checkoutcargo check --target riscv64gc-unknown-linux-gnu --testsin xsvcargotest <cargo> <out-dir> xsv(394 selected tests passed on x86_64)The full test suite has not been run on RISC-V hardware.