Skip to content

Remove crates.io compiler-builtins from the library workspace #142265

Closed
Closed
Remove crates.io compiler-builtins from the library workspace#142265
Assignees
tgross35
Labels
A-compiler-builtinsArea: compiler-builtins (https://github.com/rust-lang/compiler-builtins)C-cleanupCategory: PRs that clean code up or issues documenting cleanup.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Description

@tgross35
tgross35
opened on Jun 9, 2025

After #141993 we should eliminate compiler-builtins from any crates that are depending on it via crates.io to remove the duplicate dependency so the patch isn't needed. Todo list, taken from the PR:

Updates in rust-lang/rust:

Activity

  1. rustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jun 9, 2025
  2. tgross35
    added
    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.
    T-libsRelevant to the library team, which will review and decide on the PR/issue.
    A-compiler-builtinsArea: compiler-builtins (https://github.com/rust-lang/compiler-builtins)
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jun 9, 2025
  3. tgross35
    self-assigned this
    on Jun 9, 2025
  4. tgross35
    added 2 commits that reference this issue on Jun 10, 2025

    Update dependencies in `library/Cargo.lock`

    dd7621d

    Update dependencies in `library/Cargo.lock`

    096c29a
  5. workingjubilee
    added a commit that references this issue on Jun 11, 2025

    Rollup merge of rust-lang#142276 - tgross35:update-library-lockfile, …

    b693447
  6. tgross35
    added 4 commits that reference this issue on Jun 11, 2025

    Update dependencies in `library/Cargo.lock`

    457a4c4

    Upgrade the standard library `object` version

    1ec8045

    Upgrade the standard library `addr2line` version

    1f6abbb

    Upgrade `gimli` to 0.32.0

    f29efd0
  7. nbdd0121
    added a commit that references this issue on Jun 11, 2025

    Upgrade `gimli` to 0.32.0

    46cb055
  8. workingjubilee
    added a commit that references this issue on Jun 12, 2025

    Rollup merge of rust-lang#142276 - tgross35:update-library-lockfile, …

    04497e6

  9. 12 remaining items

  10. github-actions
    added 5 commits that reference this issue on Jun 18, 2025

    Update dependencies in `library/Cargo.lock`

    c842466

    Upgrade the standard library `object` version

    743d005

    Upgrade the standard library `addr2line` version

    b8e0586

    Rollup merge of rust-lang#142276 - tgross35:update-library-lockfile, …

    5442843

    Rollup merge of rust-lang#142308 - tgross35:upgrade-library-object, r…

    7cbbd14
  11. tgross35
    added 2 commits that reference this issue on Jun 19, 2025

    Update library dependencies

    e14e137

    Rollup merge of rust-lang#142753 - tgross35:library-lockfile, r=Mark-…

    bb72cc7
  12. rust-timer
    added a commit that references this issue on Jun 20, 2025

    Unrolled build for #142753

    a9a0198
  13. tautschnig
    added 2 commits that reference this issue on Jul 3, 2025

    Update library dependencies

    a9855f1

    Rollup merge of rust-lang#142753 - tgross35:library-lockfile, r=Mark-…

    5ad5d60

  14. tshepang commented on Aug 19, 2025

    @tshepang
    tshepang
    on Aug 19, 2025
    Member

    should this remain open

  15. bjorn3 commented on Aug 19, 2025

    @bjorn3
    bjorn3
    on Aug 19, 2025
    Member

    I think the patch at

    rust/library/Cargo.toml

    Line 62 in 8365fcb

    compiler_builtins = { path = "compiler-builtins/compiler-builtins" }
    would need to be removed.

    Also there are still crates on crates.io that depend on compiler-builtins: https://crates.io/crates/compiler_builtins/reverse_dependencies But I don't think that necessarily needs to block closing this issue.

  16. tgross35 commented on Aug 19, 2025

    @tgross35
    tgross35
    on Aug 19, 2025
    MemberAuthor

    Yeah I was just waiting to remove the patch, with the recent unwinding release that should be possible now. I'll put up a PR.

    Edit: #145622

  17. lqd commented on Aug 20, 2025

    @lqd
    lqd
    on Aug 20, 2025
    Member

    Fixed by #145622

  18. lqd
    closed this as completedon Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-compiler-builtinsArea: compiler-builtins (https://github.com/rust-lang/compiler-builtins)C-cleanupCategory: PRs that clean code up or issues documenting cleanup.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions