Skip to content

feat: canvas hide_local_filters option to hide local filter chips on a component - #9928

Merged
nishantmonu51 merged 2 commits into
mainfrom
nishant/canvas-hide-local-filters
Sep 24, 2026
Merged

nishantmonu51 merged 2 commits into
mainfrom
nishant/canvas-hide-local-filters

Conversation

@nishantmonu51

Copy link
Copy Markdown
Collaborator

Adds a per-component hide_local_filters: true option for canvas dashboards that hides the local filter chips from the component header while the local dimension_filters / time_filters still apply to the component's queries.

  • ComponentHeader.svelte skips the chip row when the flag is set; the query path in BaseCanvasComponent is untouched, so PDF export and embeds pick this up too.
  • New "Show filters on component" switch at the bottom of the inspector's Time & filters tab, ON by default and only shown once the component would render chips (same resolveTimeFilters check as the header). Turning it back on deletes the key instead of writing false.
  • No Go/proto/schema changes; component props pass through as an opaque struct.
  • Docs: canvas build guide and the AI canvas instructions (runtime/ai/instructions/data/resources/canvas.md).
  • Extends the canvas/filters.spec.ts e2e test to assert chips disappear while the filtered value stays.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

# Conflicts:
#	runtime/ai/instructions/data/resources/canvas.md
#	web-common/src/features/canvas/ComponentHeader.svelte
@nishantmonu51
nishantmonu51 merged commit 15f6b3b into main Sep 24, 2026
18 checks passed
@nishantmonu51
nishantmonu51 deleted the nishant/canvas-hide-local-filters branch September 24, 2026 05:46
nishantmonu51 added a commit that referenced this pull request Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants