Repository navigation
Make opening driver connections cancellable via a ctx - #9909
Merged
Merged
Conversation
begelundmuller
commented
Sep 30, 2026
k-anshul
reviewed
Oct 1, 2026
k-anshul
approved these changes
Oct 1, 2026
nishantmonu51
pushed a commit
that referenced
this pull request
Oct 16, 2026
* Make opening driver connections cancellable via a `ctx` * Don't let DuckDB per-connection init queries observe the open ctx * Don't let the open ctx deadline break readonly ClickHouse connections * Use t.Context() in tests and share the readonly ctx rule in ClickHouse * Scope the cached BigQuery client's ctx to the handle, not the first request (cherry picked from commit ce4de96)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ctxtodrivers.OpenandDriver.Open, and threads it into the blocking work each driver does at open time: the embedded ClickHouse binary download and readiness wait, dials, handshakes, pings and version checks.Openreturns, so handles must not retain it. Handle-lifetime contexts are now namedbgctxto keep the two apart.storage.Client.OpenBucketcapturing a cancellable ctx in its GCS credentials, which would have broken token refreshes on a long-lived bucket for non-service-account credential types.