Skip to content

Theme: add app-default to test app #5040

Open

Description

@christoph-jerolimov
  1. Add app-default npm dependency to the app in the theme workspace. Remove a custom sidebar or nav module from the app when there is a custom implementation.
  2. add app-default as dev dependency also to all plugins in the theme workspace. Wire it into the dev/index.ts page but only when it the dev page uses already the NFS.

Activity

  1. christoph-jerolimov commented on Sep 29, 2026

    @christoph-jerolimov
    MemberAuthor

    /fs-triage

  2. fullsend-ai-triage commented on Sep 29, 2026

    @fullsend-ai-triage

    🤖 Finished Triage · ✅ Success · Started 3:28 PM UTC · Completed 3:32 PM UTC

    Commit: ee3843f · View workflow run →

    Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $0.71

  3. fullsend-ai-triage commented on Sep 29, 2026

    @fullsend-ai-triage

    Analysis

    Only the theme plugin uses the New Frontend System in its dev page (dev/index.tsx uses createApp from @backstage/frontend-defaults). The other plugins (bcc-test, bui-test, mui4-test, mui5-test) all use the legacy createDevApp — so task 2 applies only to plugins/theme.

    The custom devSidebarContent (via NavContentBlueprint) and devNavModule (via createFrontendModule) in plugins/theme/dev/index.tsx can be replaced by importing the appropriate module from @red-hat-developer-hub/backstage-plugin-app-defaults (which exports app-sidebar-module, app-drawer-module, and others).

    Proposed test

    # From workspaces/theme
    yarn build
    # From workspaces/theme/plugins/theme
    yarn start
    # Verify dev page loads at / with app-defaults sidebar/nav
    

    Labels: Theme workspace feature request — applying workspace/theme and feature labels per repo conventions.


    Next steps:

    • /fs-code — agent creates a PR to implement this issue
    • /fs-code <your instruction> — agent implements with your specific guidance
  4. christoph-jerolimov commented on Sep 29, 2026

    @christoph-jerolimov
    MemberAuthor

    /fs-code

  5. fullsend-ai-coder commented on Sep 29, 2026

    @fullsend-ai-coder
    Contributor

    🤖 Finished Code · ✅ Success · Started 3:48 PM UTC · Completed 4:10 PM UTC

    Commit: ee3843f · View workflow run →

    Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $4.46

  6. christoph-jerolimov commented on Oct 10, 2026

    @christoph-jerolimov
    MemberAuthor

    /fs-code

  7. fullsend-ai-coder commented on Oct 10, 2026

    @fullsend-ai-coder
    Contributor

    🤖 Finished Code · ✅ Success · Started 9:28 AM UTC · Completed 9:39 AM UTC

    Commit: 3db5685 · View workflow run →

    Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $4.42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions