Repository navigation
TypeError when comparing partial and full version #95
Description
From changelog under the 2.7.0 release:
Backwards compatibility has been kept
However there is a breaking change that prevents me from upgrading to a new version. This example behaves same for both 2.7.0 and the latest 2.8.4 version.
>>> version_1 = Version("8.0", partial=True)
>>> version_2 = Version("8.0.0")
>>> version_1 > version_2
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/thyrst/Temp/env/lib/python3.6/site-packages/semantic_version/base.py", line 463, in __gt__
return self.precedence_key > other.precedence_key
TypeError: '>' not supported between instances of 'NoneType' and 'int'
>>> version_1 >= version_2
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/thyrst/Temp/env/lib/python3.6/site-packages/semantic_version/base.py", line 468, in __ge__
return self.precedence_key >= other.precedence_key
TypeError: '>=' not supported between instances of 'NoneType' and 'int'
>>> version_1 == version_2
FalseIn the 2.6.0 version:
>>> version_1 = Version("8.0", partial=True)
>>> version_2 = Version("8.0.0")
>>> version_1 > version_2
False
>>> version_1 >= version_2
True
>>> version_1 == version_2
TrueThere should be a warning about this change in the changelog.
Instead of the TypeError I would expect just False.
Activity