You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I started playing around with this. The existence of partial make things more complicated, but likely still doable. Since it and a number of other things are already marked for removal, I think it would be best work towards that new major version, then include type hints. The decision to drop unsupported older python versions, as part of the new major version, would have an effect on how the hints we implemented.
@plannigan That's a great approach indeed, I totally support it. Let me know if you have some code to use as a basis, otherwise I'll follow your recommendation for version 3.0 :)
Actually, I do. Since I didn't get a response, I made an independent implementation in the tool I was using this library in. It isn't a full implementation because I hyper-bump-it doesn't need the reversion range specification, but I'm happy with how it ended up.
I can put it up as a PR, but I'm not sure how much work it would be to make the rest of the code base compatible with the API changes.
Activity
rbarrois commentedon Nov 4, 2022
Indeed, that's a good idea! Although the library currently provides support for old Python version — it's a semantic versioning library after all 😉
I don't have lots of time right now (either for coding or reviewing), but hope to be able to look at this over the next few weeks ;)
q-wertz commentedon Nov 4, 2022
Nice to hear :)
You want to keep the python 2.7 support?
Maybe one could use PEP 484 or don't add the type hints in the code but generate a stub file.
plannigan commentedon Jan 1, 2023
I started playing around with this. The existence of
partialmake things more complicated, but likely still doable. Since it and a number of other things are already marked for removal, I think it would be best work towards that new major version, then include type hints. The decision to drop unsupported older python versions, as part of the new major version, would have an effect on how the hints we implemented.rbarrois commentedon Feb 28, 2023
@plannigan That's a great approach indeed, I totally support it. Let me know if you have some code to use as a basis, otherwise I'll follow your recommendation for version 3.0 :)
plannigan commentedon Feb 28, 2023
Actually, I do. Since I didn't get a response, I made an independent implementation in the tool I was using this library in. It isn't a full implementation because I
hyper-bump-itdoesn't need the reversion range specification, but I'm happy with how it ended up.I can put it up as a PR, but I'm not sure how much work it would be to make the rest of the code base compatible with the API changes.