Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuild
Command.Emptyon Base UIAutocomplete.Empty. The element stays mounted as a polite live region and shows its children only when no items match. With theitemsprop, Base UI's filtered items decide. Without it, eachCommand.Itemregisters in a small count context, because Command filters its own children.Add
Command.Status, a visually hidden live region on Base UIAutocomplete.Statusthat announces the match count while the input has text. Its children can be a function of the count. It has thecommand-statusdata-slot.Add tests, update props, demos, and the Slots table. The docs search hides its empty-state min-height when the element is empty.
Why it's like this:
Command.Emptywas built as a plain div and hidden with a CSS:has()rule. The move to Base UI (feat: migrate command to Base UI #748) kept it.Breaking: small.
Command.Emptynow shows and hides on its own. The element is always in the DOM, so custom styles with a fixed size need an:emptyrule.I have followed the pull request section of the contributing guide.