Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 27 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (20)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add anchored toasts.
toastManager.add({ title: 'Copied', positionerProps: { anchor: el } })shows the toast next toelwith an arrow. Toasts without an anchor stay in the corner stack as before.Add
showArrowtoPopover.Content(off by default). The arrow uses Tooltip's arrow styles, which move toshared/arrowso Tooltip, Popover, and Toast share one copy.Add data-slots
toast-anchored-viewport,toast-positioner,toast-arrow, andpopover-arrow, with tests and docs.Why it's like this: Toast moved to Base UI in Mar 2026 (feat: migrate Toast to Base UI #671) and only the corner toasts were ported. Base UI needs anchored toasts in a separate provider. Each Apsara manager now holds a second, internal Base UI manager, and
Toast.Providerrenders a second provider for it.addroutes bypositionerProps.anchor, andcloseandupdatego to both. This keeps onetoastManagerand oneuseToastManager(), and uses Base UI's ownpositionerPropsoption. The hook'stoastslist holds stacked toasts only. Popover's Base UI port only ported the panel it had, which never had an arrow.Breaking: no.
toastManager,useToastManager(), andcreateToastManager()keep their signatures and behavior for toasts without an anchor.I have followed the pull request section of the contributing guide.