[0.29.9] pluck inside pipe get ts error #107

Activity

1. Harris-Miller commented on Mar 5, 2024

   

   Harris-Miller

   on Mar 5, 2024

   Collaborator

   More actions

   Your R.pipe<> typings is off by a bit: R.pipe<[Data[]], (number | null)[], number[]>(), but that's not the core problem

   The problem here is due a combination of two things. First is the fact that typescript always picks the last overload when you pass a function as a prop. And R.reject has this:

   export function reject<A, P extends A>(
     pred: (val: A) => val is P,
   ): {
     <B extends A>(list: readonly B[]): Array<Exclude<B, P>>;
     <B extends A>(dict: Record<string, B>): Record<string, Exclude<B, P>>;
   };

   R.reject(R.isNil) falls into this and so in your R.pipe, The R.reject is expecting a Record<string, B> and not a B[]. But R.pluck() is now, correctly, returning B[] (#71 fixed that, before it was returning an obj, not an array of objects like it should have, this is why you didn't have the problem before)

   Since most use-cases for R.filter and R.reject is to pass a list and not an object, the list overload should come last. That's how it is on map as well. I actually have an open MR for this: #106. I'm going to add to that MR an update for R.reject as well

   The second is how the new R.pluck is what I have been calling "the collapsing generics problem". You can read about it all here: #54

   The tl;dr is because R.Pluck supports both and object and an array, the generic collapses to unknown, This is specifically due to the fact that there is more than one overload. If you use only one overload, the generic transfers. You can see this in action here: https://tsplay.dev/m3qojw

   A short-term fix for you is to not use the curried varieties of those functions, and wrap them with arrow functions in your pipe

   const extract = R.pipe<[Data[]], (number | null)[], number[]>(
     x => R.pluck("value", x),
     x => R.reject(R.isNil, x),
   );

   This is far from ideal, but will get around the typing problem until we can release a fix

   👍React with 👍2Reacted by Nathan Fok and adajoy

   👀React with 👀1Reacted by adajoy
2. nathan1530 commented on Mar 6, 2024

   

   nathan1530

   on Mar 6, 2024

   Author

   More actions

   Thank you for responding so quickly. I will use the workaround for now.