Incompatible with multiple apps with different translations #107

Activity

1. davidism commented on Jul 27, 2016

   

   davidism

   on Jul 27, 2016

   Contributor

   More actions

   For reference, Flask-SQLAlchemy implements a get_app method and uses that anywhere an app is required.
2. timothyqiu commented on Oct 15, 2016

   

   timothyqiu

   on Oct 15, 2016

   More actions

   The same goes for localeselector and timezoneselector. They are bound to the Babel instance, so can't be configured separately for different apps 😢

   FYI, Flask-SQLAlchemy and Flask-Mail store app specific states in app.extensions['NAME'].
3. TkTech

   added 3 commits that reference this issue on Jan 16, 2023

   Start moving everything off of the Babel() and app instances and stor…

   ...

   9d12cc9

   Tests for #107.

   f17b04b

   Update more documentation for #107.

   0a4da03
4. TkTech

   closed this as completedon Jan 16, 2023
5. guydavis commented on Jan 16, 2023

   

   guydavis

   on Jan 16, 2023

   Last edited by guydavis

   More actions

   Hi, I am trying out version 3.0 that was just released and am hitting the deprecation in __init__.py of a Flask app of:

   @babel.localeselector
   def get_locale():
       ....
   

   What is the recomended approach to use instead of above, to be compatible with Flask-Babel v3.0? Thanks!

   EDIT: As best I can tell, before the upgrade with the old decorator, this get_locale method was getting called per-request. After the upgrade (dropping the decorator line), the method is no longer called and my app pages are no longer translated.

   EDIT2: Sorry, my mistake. I found the answer digging into the diffs made to the documentation above. Leaving the answer for any others who hit this on upgrade to v3.0.

   My old code:

   babel = Babel(app)
   
   @babel.localeselector
   def get_locale():
       ...
   

   Changed to work with Flask-Babel v3.0:

   def get_locale():
       ...
   
   
   babel = Babel(app, locale_selector=get_locale,)
   

   ❤️React with ❤️2Reacted by neurino and Dan Stewart
6. ethhics

   added a commit that references this issue on Feb 21, 2023

   application: Update Babel syntax for new v3 format

   ...

   40eded6