Repository navigation
Set up delvewheel as the default repair wheel command for Windows - #2831
Conversation
|
One of the concerns we had was listed in #2047 (comment), about users having to add |
|
Thanks, I appreciate that:) I'll just reiterate that IMO this is a more general Windows limitation, they don't have a proper system package manager (EDIT: though I did see a |
Suggested-by: Nils <nilsnolde@proton.me>
Good point, thanks @nilsnolde. I agree that vcpkg is the closest to this kind of thing out there (and even Meson wraps is one more option). I added a note in 8cfdbf7. Does that suffice? :) |
This comment was marked as resolved.
This comment was marked as resolved.
@agriyakhetarpal IMO sounds perfect, thanks! |
|
Let's see if this works! |
|
Something is pulling in 26.1.1 from a venv somewhere, but I can't yet figure out what. It's stopping the tests from proceeding, then moving on to the tests we actually want to see run (the C extension with an unfindable DLL). |
joerick
left a comment
There was a problem hiding this comment.
Brilliant, that's perfect.
I'd reckon our integration tests do cover auditwheel, because the 'manylinux' filename is set by that tool. Not checking delocate on macOS is maybe an opportunity for better test coverage :) |
Reference: pypa/cibuildwheel#2831 Adapting from pyproject.toml change in cyndilib/cyndilib#94
Reference: pypa/cibuildwheel#2831 Adapting from pyproject.toml change in cyndilib/cyndilib#94
This PR adds
delvewheelin the usual places for it to the default wheel repair command for our Windows platform in cibuildwheel v4. The current version is v1.12.0, and the project has become fairly stable as of 2026.I think I covered everything, but please LMK if I missed anything. @joerick, since you expressed interest in adding this in various issues, it'd be great if you could take a look – and by all means, please feel free to push any further changes to my PR!
Also, cc: @adang1345 (I hope it is okay for us to ping you here!)
Thank you! :)
delvewheelas default for windows repair command #2803Also, perhaps we should look at #1567 too while we're at it, based on the open issues that reference "delvewheel".