Repository navigation
Conversation
…#3204) ## Summary A section whose `<summary>` shares its line with the `<details>` that opens it was not a heading line to `sibling_heading`, so a sibling opened that way never bounded the block before it. A suppressed block then ran on into a following previously-missed section and printed its findings twice, under the suppressed banner. Each kind's reader still found its own section, so the vetted-but-unread check had nothing to report. - `HEADING` admits a `<details>` opener ahead of `<summary>` on the same line, through a shared `DETAILS_OPENER` pattern. - `heading_of` reads past that opener where a summary follows it on the line. Without that, a count opening such a heading (`<strong>2 previously missed issues</strong>`) went unread: the section counted as one finding and its sibling never bounded, where the base had reported the body as unrecognized. The local strict review found this regression in the first cut. ## Tests - `test_a_section_opening_on_its_details_line_bounds_the_one_before` runs a count-closing and a count-opening previously-missed heading after a one-line suppressed section. Both subtests fail on the base. With only the `heading_of` change reverted, the count-opening one fails. - Full suite: 2969 tests OK, 7 skipped. Ruff, mypy, and the prose gate in both modes are clean. ## Local review Three recorded passes at the `frontier` tier. The first two raised findings that were fixed in this branch, and the third raised none. Refs #3201 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved parsing of headings inside HTML `<details>` sections, including headings that share a line with the opening tag. * Updated tag matching to handle standard HTML whitespace consistently. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 44 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🔵 Needs a closer look
A moderate parsing issue remains in the <summary> tag matching branch.
No open issues 🎉
What changed in this PR
Updates pr_review.py to correctly parse one-line <details><summary> sections and HTML whitespace, with regression coverage.
Changes:
- Fixes section boundaries and heading extraction.
- Adds tests for inline sections and whitespace handling.
- Requires a tag-name boundary after
<summary>in one parsing branch.
| File | Description |
|---|---|
tests/test_pr_review.py |
Adds regression coverage for section boundaries and whitespace. |
scripts/pr_review.py |
Updates section parsing, heading detection, and folding patterns. |
Review effort: Lite
|
Answering the headline of Copilot's round on 213ac082, which opened no thread and counted 0 findings ( Deferred to #3206. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3205 +/- ##
==========================================
+ Coverage 65.48% 65.49% +0.01%
==========================================
Files 17 17
Lines 9754 9758 +4
==========================================
+ Hits 6387 6391 +4
Misses 3367 3367
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
|
pr_review.pybound a section whose<summary>shares its line with the<details>that opens it. A suppressed block used to run on into a following previously-missed section opened that way and print its findings twice, with nothing reporting the shape.heading_ofreads past the same opener, so a count opening such a heading is read. The attribute separator after a tag name inDETAILS_OPENER,SUMMARY,FOLD_OPENER, andFOLD_STOPis now HTML whitespace rather than Python's\s.The change is to scripts and tests only, so no installed Skill changes at release.
Closes #3201
🤖 Generated with Claude Code