Repository navigation
Remove jquery dependency - #3678
Merged
Merged
Conversation
jcoyne
force-pushed
the
remove-more-jquery
branch
from
June 13, 2026 17:06
65294e6 to
99e378e
Compare
jcoyne
marked this pull request as ready for review
June 15, 2026 13:38
jcoyne
force-pushed
the
remove-more-jquery
branch
3 times, most recently
from
June 17, 2026 16:03
68b47e9 to
5a2af43
Compare
jcoyne
force-pushed
the
remove-more-jquery
branch
from
June 23, 2026 16:28
4b2ce23 to
2aab42d
Compare
jcoyne
force-pushed
the
remove-more-jquery
branch
from
June 23, 2026 22:32
406209d to
856bc0f
Compare
jcoyne
force-pushed
the
remove-more-jquery
branch
from
August 30, 2026 19:39
856bc0f to
6f09d68
Compare
jcoyne
force-pushed
the
remove-more-jquery
branch
3 times, most recently
from
September 10, 2026 19:46
8b0c5d4 to
65e4a44
Compare
jcoyne
force-pushed
the
remove-more-jquery
branch
2 times, most recently
from
October 7, 2026 18:32
6697676 to
1f10ef5
Compare
jcoyne
force-pushed
the
remove-more-jquery
branch
3 times, most recently
from
October 7, 2026 20:42
edc863c to
090f6df
Compare
corylown
requested changes
Oct 8, 2026
corylown
left a comment
Contributor
There was a problem hiding this comment.
This is looking really good, just seeing just a couple of things:
- On the exhibits admin Users page (
/spotlight/{exhibit-slug}/users) the Edit, Cancel, Delete buttons are missing after clicking on the edit/pencil icon to make changes to an existing user.
- See inline comments about the carousel.js
jcoyne
force-pushed
the
remove-more-jquery
branch
2 times, most recently
from
October 8, 2026 15:45
46e886b to
4102cd3
Compare
This involved dumping the jquery.jsonserialize.js script an adding a vanilla js replacement
jcoyne
force-pushed
the
remove-more-jquery
branch
from
October 8, 2026 16:28
4102cd3 to
b050ba7
Compare
corylown
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completely removes jquery dependency.
closes #3683