Repository navigation
Add h1 heading to blog index page (#223) - #451
Open
mayankgandhi13 wants to merge 1 commit into
Open
mayankgandhi13 wants to merge 1 commit into
mayankgandhi13 wants to merge 1 commit into
Conversation
The blog listing had no level-one heading, which axe-core flags (page-has-heading-one). Render the section title as an h1, using the same styling as the other section index pages (Resources, Topics, etc.). Fixes posit-dev#223
✅ Deploy Preview for posit-open-source canceled.
|
Contributor
Preview not availableThis PR is from a fork and cannot deploy a preview automatically. |
Collaborator
|
/deploy-preview |
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite check
Related Issue
Closes #223
Description of changes
/blog/had no<h1>, which axe-core flags (page-has-heading-one). This adds the section title ({{ .Title }}, i.e. "Blog") as an<h1>at the top oflayouts/blog/list.html. It uses the same classes as the other section index pages (text-4xl font-medium text-gray-500, as on Resources, Topics, Events and People), so the blog index now matches them.I built the site locally with Hugo 0.158.0 (the version CI uses). All 18 blog listing pages (
/blog/,/blog/page/2/, …) now have exactly one<h1>.Screenshots or previews (if applicable)
Checklist
CONTRIBUTING.mdguidelines.