Skip to content

return an aclose-able AsyncGenerator from Template.generate_async - #1957

Closed
graingert wants to merge 3 commits into
pallets:mainfrom
graingert:patch-1
Closed

graingert wants to merge 3 commits into
pallets:mainfrom
graingert:patch-1

Conversation

@graingert

@graingert graingert commented Apr 7, 2024 •

Copy link
Copy Markdown
Contributor

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@graingert
graingert marked this pull request as ready for review April 7, 2024 17:23
Comment thread CHANGES.rst Outdated
@davidism

Copy link
Copy Markdown
Member

Superseded by #1960

@davidism davidism closed this May 11, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

generate_async type annotation does not support .aclose()

2 participants