Repository navigation
Remove unused bindings and constants from _winconsole - #3817
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These constants are not used anywhere, so I would classify them as left-over from the previous Python 2 cleanup that was performed by @Rowlando13 in #3695 or @davidism in 00883dd.
These were introduced 11 years ago in Click 6.x (see bcf8fec) for Python 2 compatibility and not touched since then.
And because this module is private, I choose not to add a changelog. Just tell me if you think it needs one and I will update this PR.