Repository navigation
feat: wire typography tokens and add Storybook playground - #8308
Draft
datahobbit26 wants to merge 7 commits into
Draft
datahobbit26 wants to merge 7 commits into
datahobbit26 wants to merge 7 commits into
Conversation
Generate changelog in
|
feat(core): use font-family token and add Storybook controlsBuild artifact links for this commit: documentation | landing | table | demo | storybookThis is an automated comment from the deploy-preview CircleCI job. |
feat: reveal custom font editor from preset dropdownBuild artifact links for this commit: documentation | landing | table | demo | storybookThis is an automated comment from the deploy-preview CircleCI job. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Wire Blueprint's existing
--bp-typography-family-default,--bp-typography-family-mono,--bp-typography-weight-default,--bp-typography-weight-bold,--bp-typography-line-height-default, and--bp-typography-line-height-largetokens into shared text styles and explicit consumers in core, datetime, datetime2, and table. Applications can customize typography at runtime while retaining the current default fonts, weights 400/600, and unitless line heights 1.28581/1.5. Font sizes, heading/code-block line heights, and control alignment retain their existing styles.Add a compact Core / Typography / Playground overview of headings, component titles, breadcrumbs, menus, table headers, calendar labels, code, and regular controls. The Theme panel opens on the right and shows only the six typography tokens for this story, with font-family presets and custom stacks, individual resets, and reset-all. Numeric controls start from the token definitions. Load Normalize.css so native controls inherit typography.
Reviewers should focus on:
In the Typography playground, vary bold and regular weights independently and compare titles, calendar labels, table headers, and body text. Try the font-family presets, custom stacks, and both line heights, then open the portaled menu and switch themes or stories. Use the individual reset buttons or Reset all to restore defaults.