You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Sonar S125 is load-dependent: prose comment lines ending in ';' fail the build on a starved runner #1216
CI run 37661989678 (job templates) failed on main 55bb9bc with src/Rask.Ui/UiChoice.cs(59,5): error S125: Remove this commented out code on a file untouched since 7a9861d; the same pack command was green in eight other jobs of that run. Fixed for that file in dfb5a9c by ending the sentence with a full stop.
Mechanism (read from SonarAnalyzer.CSharp 10.34.0.3385 source, CommentedOutCode.cs): a comment line ending in ; counts as code unless SentencePattern.SafeMatch succeeds; that regex runs with a 100 ms WALL-CLOCK timeout and SafeMatch swallows the timeout, so on a starved machine a prose line becomes 'code'. Not reproduced locally (inferred).
Still exposed (prose comment lines ending in ';'):
To do: reword those lines (line numbers as of 2d2ea79), and add a fast guard (a test or an analyzer-free grep in the format gate) that fails on a comment line ending in ';' so it cannot come back. Related: RaskDomEmit also has a wall-clock regex timeout that failed a local build at load 340.
Activity