Skip to content

Create shared projects to fix problems with the examples - #5

Merged
objorke merged 6 commits into
oxyplot:masterfrom
mennodeij:create_shared_projects
Jan 12, 2018
Merged

objorke merged 6 commits into
oxyplot:masterfrom
mennodeij:create_shared_projects

Conversation

@mennodeij

Copy link
Copy Markdown
Contributor

I have updated the solution and project structure so that OxyPlot.GtkSharp and OxyPlot.GtkSharp3 both use a shared project OxyPlot.GtkSharp.Shared. The same approach was used to fix the Examples.

The dependencies to OxyPlot.Core have all be updated to 2.0.0-unstable1013, the latest 2.0.0 version on nuget.org. There were older references to OxyPlot.Core, called 2015.*; all these references are now removed, also from e.g. the app.config files).

Furthermore, the GtkSharp3 examples do not run on Windows due to the missing support for gtksharp3 on the Windows platform (only gtksharp 2.x can be downloaded and installed for Windows). On Linux, however, the GtkSharp3 examples run without problems.

This was referenced Jan 12, 2018
@mennodeij

Copy link
Copy Markdown
Contributor Author

Ok, it is working now. Apparently, there is a bug in VS2017 when "lightweight-load solution" is on (which it is by default), that once it encounters a .shproj file any other projects listed after that .shproj file will not get built. By moving all .shproj files to the end of the list of projects, the build by Appveyor now proceeds normally.
One thing I'm wondering about is the current versioning (0.1.0) It puts the 0.1.0 NuGet package at the bottom of the list at https://www.myget.org/feed/oxyplot/package/nuget/OxyPlot.GtkSharp

@objorke

objorke commented Jan 12, 2018

Copy link
Copy Markdown
Member

This looks great! Thanks for the contribution!

@objorke
objorke merged commit 56288b9 into oxyplot:master Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants