Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #808 (point 1: a clearer error when unrar fails).
Previously a failure reported by unrar was shown as e.g.
without the entry concerned nor any hint. This maps unrar's
Code/Whento a descriptive message with hints (file name too long / permissions forECreate, corrupted archive forBadData/BadArchive, missing or wrong password ->--password, etc.) and reports the archive entry being extracted:Adds a UI snapshot test with a small RAR5 fixture (350 bytes, stored) whose single entry name is 300 bytes, which triggers
ECreate. Other codes fall back to unrar's own text when not mapped.Tested with
--no-default-features --features unrar,use_zlib,use_zstd_thin(bzip3 needs libclang, which I don't have locally) and without theunrarfeature; clippy and nightly rustfmt are clean.Not covered: skipping failing entries and extracting a single file (points 2 and 3 of the issue).