Repository navigation
Conversation
The service had no health endpoint, so a liveness or readiness probe had nothing to point at, and it logged only with the standard logger, so there was nothing to correlate against a trace. - /healthz for liveness, reporting on the process only - /readyz for readiness; this service has no dependencies, so it is ready as soon as it is listening - JSON logs carrying trace_id and span_id, plus the name served, whether it was defaulted, and how long the request took - OpenTelemetry traces over OTLP, with context propagation, so a caller that forwards trace headers shares one trace with this service - PORT and LOG_LEVEL are configurable, defaulting to 9090 and info The greeting contract is unchanged: GET /greeter/greet?name= still answers "Hello, <name>!" and still defaults to Stranger. Tracing is best-effort and disabled when no OTLP endpoint is set. Go moves to 1.26 in go.mod and the Dockerfile, which the OpenTelemetry modules require. Signed-off-by: Ketharan <ketharan.mail@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
service-go-greeterhad no health endpoint, so a liveness or readiness probe had nothing topoint at, and it logged with the standard logger, so there was nothing to correlate against a
trace.
Approach
/healthzfor liveness, reporting on the process only/readyzfor readiness; the service has no dependencies, so it is ready once it is listeningtrace_idandspan_id, the name served, whether it was defaulted, andthe request duration
headers shares one trace with this service
PORTandLOG_LEVELare configurable, defaulting to 9090 and infoThe greeting contract is unchanged:
GET /greeter/greet?name=still answersHello, <name>!and still defaults to
Stranger. Tracing is best-effort and disabled when no OTLP endpoint isset. Go moves to 1.26 in
go.modand the Dockerfile, which the OpenTelemetry modules require.Checklist